[FMT] made clippy happy, and ran cargo fmt

Author: Shifta-Robel

core/examples/advanced_tool_calls.rs

@@ -95,14 +95,14 @@ async fn main() -> Result<(), seedframe::error::Error> {
         .send()
         .await?;
 
-    println!("Meeting scheduled: {:#?}", response);
+    println!("Meeting scheduled: {response:#?}");
 
     let response = client
         .prompt("convert the temperature 32.2 from Celcius to Fahrenheit")
         .send()
         .await?;
 
-    println!("Temprature converted : {:#?}", response);
+    println!("Temprature converted : {response:#?}");
 
     Ok(())
 }

core/examples/extractors.rs

@@ -39,7 +39,7 @@ async fn main() -> Result<(), seedframe::error::Error> {
     let person = client.prompt(person_text)
         .extract::<Person>()
         .await?;
-    println!("Extracted Person:\n{:#?}\n", person);
+    println!("Extracted Person:\n{person:#?}\n");
 
     let meeting_text = "We have a team meeting scheduled for 2026-2-15 at 11:30. \
                        Purpose is quarterly planning. Attendees include: \
@@ -49,7 +49,7 @@ async fn main() -> Result<(), seedframe::error::Error> {
     let meeting = client.prompt(meeting_text)
         .extract::<MeetingDetails>()
         .await?;
-    println!("Extracted Meeting:\n{:#?}\n", meeting);
+    println!("Extracted Meeting:\n{meeting:#?}\n");
 
     Ok(())
 }

core/src/completion/mod.rs

@@ -140,34 +140,34 @@ impl<'a, M: CompletionModel> PromptBuilder<'a, M> {
     }
 
     /// Execute the tool calls if the LLM responds with a Tool call request, `true` by default
-    pub fn execute_tools(mut self, execute: bool) -> Self {
+    #[must_use] pub fn execute_tools(mut self, execute: bool) -> Self {
         self.execute_tools = execute;
         self
     }
 
     /// Wether to send any tool definitions with the prompt, `true` by default
-    pub fn with_tools(mut self, no_tools: bool) -> Self {
+    #[must_use] pub fn with_tools(mut self, no_tools: bool) -> Self {
         self.with_tools = no_tools;
         self
     }
 
     /// Create a `Message::User` with the tool reponses and append it to the client history, `false` by default
-    pub fn append_tool_response(mut self, append: bool) -> Self {
+    #[must_use] pub fn append_tool_response(mut self, append: bool) -> Self {
         self.append_tool_response = append;
         self
     }
 
     /// Wether to retrieve and append the context to the prompt, true by default.
     /// If true, the client's vector store will get looked up for the top matches to the prompt and
     /// the context will get appended to the prompt before being sent.
-    pub fn with_context(mut self, append_context: bool) -> Self {
+    #[must_use] pub fn with_context(mut self, append_context: bool) -> Self {
         self.with_context = append_context;
         self
     }
 
     /// Prompt the LLM with a custom history, and get a response.
     /// Response won't be stored in the client's history
-    pub fn one_shot(mut self, one_shot: bool, history: Option<MessageHistory>) -> Self {
+    #[must_use] pub fn one_shot(mut self, one_shot: bool, history: Option<MessageHistory>) -> Self {
         self.one_shot = (one_shot, history);
         self
     }
@@ -254,14 +254,14 @@ impl<'a, M: CompletionModel> PromptBuilder<'a, M> {
             } = response.clone()
             {
                 if self.one_shot.0 {
-                    self.client.history.push(response)
+                    self.client.history.push(response);
                 }
                 let values = self.client.run_tools(Some(&calls)).await?;
                 if self.one_shot.0 {
                     self.client.history.pop();
                 }
                 response = Message::User {
-                    content: "".to_owned(),
+                    content: String::new(),
                     tool_responses: Some(values.clone()),
                 };
                 if self.append_tool_response && !self.one_shot.0 {
@@ -304,7 +304,7 @@ impl<M: CompletionModel + Send> Client<M> {
         self.history = history;
     }
 
-    pub fn export_history(&self) -> &MessageHistory {
+    #[must_use] pub fn export_history(&self) -> &MessageHistory {
         &self.history
     }
 
@@ -408,7 +408,7 @@ impl<M: CompletionModel + Send> Client<M> {
         };
 
         let message_with_context = Message::User {
-            content: format!("{}{}", prompt, context),
+            content: format!("{prompt}{context}"),
             tool_responses: None,
         };
 
@@ -431,7 +431,7 @@ impl<M: CompletionModel + Send> Client<M> {
             return Ok(None);
         }
         let mut context = String::new();
-        for embedder in self.embedders.iter() {
+        for embedder in &self.embedders {
             let query_results = embedder.query(prompt, DEFAULT_TOP_N).await?;
             if query_results.is_empty() {
                 return Ok(None);
@@ -476,11 +476,11 @@ fn process_json_value(value: &mut serde_json::Value) {
     match value {
         serde_json::Value::Object(obj) => {
             let fields_to_remove = ["$schema", "format", "title", "minimum"];
-            fields_to_remove.iter().for_each(|&f| {
+            for &f in &fields_to_remove {
                 if obj.get(f).map_or(false, |v| v.is_string() || v.is_number()) {
                     obj.remove(f);
                 }
-            });
+            }
             if let Some(v) = obj.get("oneOf").cloned() {
                 obj.remove("oneOf");
                 obj.insert("anyOf".to_string(), v);
@@ -521,7 +521,7 @@ where
     S: Serializer,
 {
     let combined_content = match tool_calls {
-        Some(calls) => &format!("{} {:?}", content, calls),
+        Some(calls) => &format!("{content} {calls:?}"),
         None => content,
     };
     serializer.serialize_newtype_struct("assistant", &combined_content)

core/src/document.rs

@@ -9,7 +9,7 @@ pub struct Document {
 }
 
 impl Document {
-    pub fn new(id: String, data: String) -> Self {
+    #[must_use] pub fn new(id: String, data: String) -> Self {
         Self { id, data }
     }
 }

core/src/loader/builtins/file_loaders/file_once_loader.rs

@@ -53,7 +53,7 @@ impl FileOnceLoaderBuilder {
         let documents = load_initial(&self.evaluated);
         if documents.is_empty() {
             error!("No documents matched the provided glob patterns");
-            Err(FileLoaderError::NoMatchingDocuments)?
+            Err(FileLoaderError::NoMatchingDocuments)?;
         };
         let (tx, _rx) = broadcast::channel(documents.len());
         debug!(
@@ -100,7 +100,7 @@ impl Loader for FileOnceLoader {
                 if let Err(e) = self.tx.send(doc.clone()) {
                     error!("Loader failed to send document: {} to subscribers", e.0.id);
                 } else {
-                    sent_docs_count += 1
+                    sent_docs_count += 1;
                 }
             }
             info!(
@@ -147,7 +147,7 @@ mod tests {
             "*.txt *.pdf",
         ]
         .iter()
-        .map(|p| p.to_string())
+        .map(|p| (*p).to_string())
         .collect::<Vec<String>>();
         let result = FileOnceLoaderBuilder::new(invalid_patterns);
         assert!(result.is_err());

core/src/loader/builtins/file_loaders/file_updating_loader.rs

@@ -70,7 +70,7 @@ impl FileUpdatingLoaderBuilder {
     /// # Returns
     /// * `FileUpdatingLoader` - A new `FileUpdatingLoader` instance.
     pub fn build(self) -> FileUpdatingLoader {
-        let files = resolve_input_to_files(self.glob_patterns.iter().map(|s| s.as_str()).collect())
+        let files = resolve_input_to_files(self.glob_patterns.iter().map(std::string::String::as_str).collect())
             .unwrap();
         let capacity = if files.is_empty() {
             DEFAULT_CHANNEL_CAPACITY
@@ -122,13 +122,13 @@ impl Loader for FileUpdatingLoader {
             let initial_docs = load_initial(&self.patterns);
             let mut sent_docs_count = 0;
             let total_docs_count = initial_docs.len();
-            initial_docs.into_iter().for_each(|doc| {
+            for doc in initial_docs {
                 if let Err(e) = self.tx.send(doc) {
                     error!("Loader failed to send document: {} to subscribers", e.0.id);
                 } else {
                     sent_docs_count += 1;
                 }
-            });
+            }
             info!(
                 "Loader sent {} of {} initial documents to subscribers",
                 sent_docs_count, total_docs_count
@@ -169,7 +169,7 @@ impl Loader for FileUpdatingLoader {
                 loop {
                     let now = Instant::now();
                     if now.duration_since(last_event_time) >= debounce_duration {
-                        for event in evt_rx.iter() {
+                        for event in &evt_rx {
                             let event = event.unwrap();
                             let out = process_event(&event, &pc);
                             if out.is_none() {
@@ -199,7 +199,7 @@ fn document_for_event(path: &str, et: EventType) -> Document {
     let file = std::path::Path::new(&path);
     let data = match et {
         EventType::Modify | EventType::Create => parse_file(file).unwrap(),
-        EventType::Delete => "".to_string(),
+        EventType::Delete => String::new(),
     };
     debug!("Created document for {} with event type {:?}", path, et);
     Document {
@@ -243,7 +243,7 @@ mod tests {
             paths: vec![PathBuf::from("test.txt")],
             attrs: Default::default(),
         };
-        let result = process_event(&event, &vec![pattern]);
+        let result = process_event(&event, &[pattern]);
         assert!(result.is_some());
         let (path, et) = result.unwrap();
         assert_eq!(path, "test.txt");
@@ -258,7 +258,7 @@ mod tests {
             paths: vec![PathBuf::from("test.txt")],
             attrs: Default::default(),
         };
-        let result = process_event(&event, &vec![pattern]);
+        let result = process_event(&event, &[pattern]);
         assert!(result.is_none());
     }
 

core/src/loader/builtins/file_loaders/utils.rs

@@ -95,7 +95,7 @@ pub(super) fn parse_file(file_path: &Path) -> io::Result<String> {
 }
 
 pub(super) fn load_initial(patterns: &[Pattern]) -> Vec<Document> {
-    let files = resolve_input_to_files(patterns.iter().map(|s| s.as_str()).collect()).unwrap();
+    let files = resolve_input_to_files(patterns.iter().map(glob::Pattern::as_str).collect()).unwrap();
     let mut documents: Vec<Document> = vec![];
     for file in files {
         let data = parse_file(&file).unwrap();

core/src/providers/completions/deepseek.rs

@@ -16,7 +16,7 @@ pub struct DeepseekCompletionModel {
 }
 
 impl DeepseekCompletionModel {
-    pub fn new(api_key: String, api_url: String, model: String) -> Self {
+    #[must_use] pub fn new(api_key: String, api_url: String, model: String) -> Self {
         Self {
             api_key,
             client: reqwest::Client::new(),

core/src/providers/completions/openai.rs

@@ -15,7 +15,7 @@ pub struct OpenAICompletionModel {
 }
 
 impl OpenAICompletionModel {
-    pub fn new(api_key: String, api_url: String, model: String) -> Self {
+    #[must_use] pub fn new(api_key: String, api_url: String, model: String) -> Self {
         Self {
             api_key,
             client: reqwest::Client::new(),
@@ -334,7 +334,7 @@ For this test to be considered successful, reply with "okay" without the quotes,
                 content: _,
                 tool_calls: Some(_)
             }
-        ))
+        ));
     }
 
     fn get_tools() -> ToolSet {

core/src/providers/completions/xai.rs

@@ -16,7 +16,7 @@ pub struct XaiCompletionModel {
 }
 
 impl XaiCompletionModel {
-    pub fn new(api_key: String, api_url: String, model: String) -> Self {
+    #[must_use] pub fn new(api_key: String, api_url: String, model: String) -> Self {
         Self {
             api_key,
             client: reqwest::Client::new(),