Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionList discards target prop for items #12875

Open
graygilmore opened this issue Nov 4, 2024 · 0 comments
Open

ActionList discards target prop for items #12875

graygilmore opened this issue Nov 4, 2024 · 0 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@graygilmore
Copy link

graygilmore commented Nov 4, 2024

Summary

If an Item has a URL it only uses the external prop instead of allowing a custom target to be set: https://github.com/Shopify/polaris/blob/main/polaris-react/src/components/ActionList/components/Item/Item.tsx#L138-L148 This prevents the ability for the ActionList component to be used inside of an iframe where we want to set the target to _top.

Expected behavior

ActionList items should accept a target prop (this can be in addition to or instead of external).

Actual behavior

ActionList items ignore the target prop.

You can see that even though TypeScript accepts a target prop on the items it doesn't get used.

Are you using React components?

  • ActionList
  • Item
@graygilmore graygilmore added Bug Something is broken and not working as intended in the system. untriaged labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

1 participant