We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target
If an Item has a URL it only uses the external prop instead of allowing a custom target to be set: https://github.com/Shopify/polaris/blob/main/polaris-react/src/components/ActionList/components/Item/Item.tsx#L138-L148 This prevents the ability for the ActionList component to be used inside of an iframe where we want to set the target to _top.
Item
external
ActionList
_top
ActionList items should accept a target prop (this can be in addition to or instead of external).
ActionList items ignore the target prop.
You can see that even though TypeScript accepts a target prop on the items it doesn't get used.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Summary
If an
Item
has a URL it only uses theexternal
prop instead of allowing a customtarget
to be set: https://github.com/Shopify/polaris/blob/main/polaris-react/src/components/ActionList/components/Item/Item.tsx#L138-L148 This prevents the ability for theActionList
component to be used inside of an iframe where we want to set the target to_top
.Expected behavior
ActionList
items should accept atarget
prop (this can be in addition to or instead ofexternal
).Actual behavior
ActionList
items ignore thetarget
prop.You can see that even though TypeScript accepts a
target
prop on the items it doesn't get used.Are you using React components?
The text was updated successfully, but these errors were encountered: