Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexFilters tabs onAction not called on tabs in More views menu #13041

Open
timvandam opened this issue Jan 10, 2025 · 0 comments
Open

IndexFilters tabs onAction not called on tabs in More views menu #13041

timvandam opened this issue Jan 10, 2025 · 0 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@timvandam
Copy link

timvandam commented Jan 10, 2025

Summary

It's possible to provide IndexFilters.tabs elements with an onAction to perform some action when the tab is clicked, but this does not work if the tab is in the More views window.

A workaround is to IndexFilters.onSelect rather than onAction.

Expected behavior

It should call onAction

Actual behavior

Wrap animated gifs/videos in a details tag:

Summary of your gif(s) Video showing More views not working

Steps to reproduce

https://polaris.shopify.com/sandbox?code=N4Igxg9gJgpiBc4IDsDOAXABAbVTANjGOjFADSZ7oDKBRJUAupgLyYCue16AhiQBQAGAJQBuADrJJAHgCSyWAA8AYgEt8JAE6pJmTAFtoMFsHlK1GmNoCyRgHQARGADMe7DQF9dlGOluwTfmFWAD5MYA8vZD1ndS1UE2xGKL0UAEV2KwBPAGEACx5kAHNjYCDQ8MjvdMzNXMIeTUDgljCIlMwUHIbNAEF8fGaK9u9eACME4F7NTR4su2dNCH1%2BYExCYvQ8%2BEwARkFBTA8KfgB9ClUWsNXvPVUoHe5NVWL%2BS7JbzEhkEh%2BdgAMACo8MaYAAkwFUHn%2BH2iek6yF6xFUKB25VaPhodGIpDewlheg8wmEHTwhBxUBMZPopCiAHoQqIQGQQFsYPoYKgENgQPgIGAeIR4DBkCBGCyAO73LZc%2BDYADsADYABzJIA

Are you using React components?

Yes

Polaris version number

13.9.2

Browser

Chrome: 131.0.6778.265

Device

macOS 15.1.1

@timvandam timvandam added Bug Something is broken and not working as intended in the system. untriaged labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

1 participant