Skip to content

Add documentation about new test explorer implementation #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinistock opened this issue Apr 28, 2025 · 5 comments
Open

Add documentation about new test explorer implementation #3421

vinistock opened this issue Apr 28, 2025 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@vinistock
Copy link
Member

With the new test explorer implemented, there are two pieces of documentation we have to update:

User documentation

We should add a new markdown page dedicated to user documentation about the explorer, explaining all of the limitations and features that we provide. Things like:

  • The modes of execution (run, run in terminal, debug, coverage)
  • Continuous mode support
  • The environment variable we provide for customization when running tests through the explorer
  • Keybindings
  • The fact that tests are discovered through static analysis and meta-programmed tests will either not be available or will only be discovered after the first run

Add-on documentation

We need to document how add-ons can contribute to test discovery and execution through the new APIs, with a simple example of how to do it.

@vinistock vinistock added the documentation Improvements or additions to documentation label Apr 28, 2025
@vinistock vinistock self-assigned this Apr 30, 2025
@domingo2000
Copy link
Contributor

Last week i tried to implement this new Test Discovery Items based on the PRs of your own implementations for the Minitest::Spec in this addon for the minitest shoulda context dsl. But i saw the test explorer was still under a feature flag in the lsp IDE settings.

¿Are you planning an official date, documentation or release when i could implement that migration from the old code lens aproach?. I will watch this issue for now.

Also willing to do the implementation on my side and after that document a simple implementation in the addon docs in this repository based on the experience gained.

@vinistock
Copy link
Member Author

We're still fixing a few issues we discovered before the rollout, but I expect we'll be starting with a small percentage some time this week or the next. I can ping this issue when we start rolling it out.

Concerning the add-on API, it has roughly three pieces:

If you have feedback about the APIs (or eventually the docs), please do let us know here! I should have something written for the docs soonish.

@vinistock
Copy link
Member Author

@domingo2000 I just put up #3488, which documents the test discovery portion of the API. Let us know if you have any feedback! We want to make it as clear as possible.

@domingo2000
Copy link
Contributor

domingo2000 commented May 17, 2025

I've added a comment to the documentation.

I've started a draft implementation for test discovery and noted some blockers encountered during development. The discovery phase was successful, populating the TestItem objects works fine. However, I encountered issues with the test command resolution step.

The main issue is that requests aren't triggered for inner groups within test classes. This problem also affects minitest/spec DSL examples (that implementation is similar to my addon) when describe syntax is under a class or have inner describe blocks. To address these integration problems with the new test explorer and both minitest/spec and my addon, ¿Should i open open a new issue or pull request to adress those problems?.

@vinistock
Copy link
Member Author

We noticed issues too and pushed some fixes last week. Are the problems you found addressed after #3497, #3500 and #3501?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants