Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow loadBalancerSourceRanges parameter signoz-otel-collector service #530

Open
MattiDeGrauwe opened this issue Oct 14, 2024 · 1 comment
Open

Allow loadBalancerSourceRanges parameter signoz-otel-collector service #530

MattiDeGrauwe opened this issue Oct 14, 2024 · 1 comment
Labels
chart:signoz Issue related to signoz helm chart enhancement New feature or request good first issue Good for newcomers

Comments

@MattiDeGrauwe
Copy link

Would it be possible to add a loadBalancerSourceRanges parameter to enable whitelisting of the otel-collector ingress service?
This makes it possible to only accept incoming otel metrics/logs from certain CIDR ranges.

We need this since we have mutliple environments connecting to our collector and as workaround we use a patch after every deploy to enable this whitelisting:

kubectl patch svc signoz-otel-collector -p '{"spec": {"loadBalancerSourceRanges": '"$IP_RANGES"'}}' -n signoz
@grandwizard28 grandwizard28 added chart:signoz Issue related to signoz helm chart enhancement New feature or request labels Oct 17, 2024
@grandwizard28
Copy link
Contributor

Hi @MattiDeGrauwe,
Would you be willing to raise a PR for this?

@grandwizard28 grandwizard28 added the good first issue Good for newcomers label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chart:signoz Issue related to signoz helm chart enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattiDeGrauwe @grandwizard28