chore: remove multi node cluster flag

Author: dhawal1248

cmd/signozschemamigrator/migrate.go

@@ -37,7 +37,6 @@ func main() {
 
 	f.String("dsn", "", "Clickhouse DSN")
 	f.String("cluster-name", "cluster", "Cluster name to use while running migrations")
-	f.Bool("multi-node-cluster", false, "True if the dsn points to a multi node clickhouse cluster, false otherwise. Defaults to false.")
 	f.Bool("disable-duration-sort-feature", false, "Flag to disable the duration sort feature. Defaults to false.")
 	f.Bool("disable-timestamp-sort-feature", false, "Flag to disable the timestamp sort feature. Defaults to false.")
 
@@ -56,11 +55,6 @@ func main() {
 		logger.Fatal("Failed to get cluster name from args", zap.Error(err))
 	}
 
-	multiNodeCluster, err := f.GetBool("multi-node-cluster")
-	if err != nil {
-		logger.Fatal("Failed to get multi node cluster flag from args", zap.Error(err))
-	}
-
 	disableDurationSortFeature, err := f.GetBool("disable-duration-sort-feature")
 	if err != nil {
 		logger.Fatal("Failed to get disable duration sort feature flag from args", zap.Error(err))
@@ -82,7 +76,6 @@ func main() {
 	managerConfig := migrationmanager.NewConfig(
 		dsn,
 		clusterName,
-		multiNodeCluster,
 		disableDurationSortFeature,
 		disableTimestampSortFeature,
 	)

migrationManager/manager.go

@@ -24,15 +24,13 @@ type Config struct {
 func NewConfig(
 	dsn string,
 	clusterName string,
-	isMultiNodeCluster bool,
 	isDurationSortFeatureDisabled bool,
 	isTimestampSortFeatureDisabled bool,
 ) Config {
 	return Config{
 		MigratorConfig: migrators.MigratorConfig{
 			DSN:                            dsn,
 			ClusterName:                    clusterName,
-			IsMultiNodeCluster:             isMultiNodeCluster,
 			IsDurationSortFeatureDisabled:  isDurationSortFeatureDisabled,
 			IsTimestampSortFeatureDisabled: isTimestampSortFeatureDisabled,
 		},

migrationManager/migrators/baseMigrator/migrator.go

@@ -41,14 +41,6 @@ func (m *BaseMigrator) Migrate(ctx context.Context, database string, migrationFo
 		return err
 	}
 
-	// drop schema migrations table if running in docker multi node cluster mode so that migrations are run on new nodes
-	if m.Cfg.IsMultiNodeCluster {
-		err := m.dropSchemaMigrationsTable(ctx, database)
-		if err != nil {
-			return err
-		}
-	}
-
 	return m.runSqlMigrations(ctx, migrationFolder, database)
 }
 

migrationManager/migrators/migrators.go

@@ -9,7 +9,6 @@ import (
 type MigratorConfig struct {
 	DSN                            string
 	ClusterName                    string
-	IsMultiNodeCluster             bool
 	IsDurationSortFeatureDisabled  bool
 	IsTimestampSortFeatureDisabled bool
 }