Bug delete secret, update security code PIN

Silbad · Silbad · commit cb49f73cc62a · 2018-02-27T22:21:51.000+01:00
diff --git a/_build/sauth-1.0.2.zip b/_build/sauth-1.0.2.zip
diff --git a/app/options.js b/app/options.js
@@ -4,7 +4,7 @@ $(function() {
     browser.storage.local.get('listSecrets').then(function(item) {
         var SAuthButtonDelete = browser.i18n.getMessage('SAuthButtonDelete');
         $.each(item.listSecrets, function( key, value ) {
-            var tmpRow = '<tr><td>' + parseInt(key + 1) + '</td><td>' + value.account + '</td><td>************</td><td class="text-danger text-right"><button class="btn btn-danger delete"></button></td></tr>';
+            var tmpRow = '<tr><td>' + parseInt(key + 1) + '</td><td>' + value.account + '</td><td data-code="' + value.code + '">************</td><td class="text-danger text-right"><button class="btn btn-danger delete"></button></td></tr>';
             $('#list-secrets tbody').append(tmpRow);
         });
         $('.delete').html(SAuthButtonDelete).on('click', function(){
@@ -72,10 +72,12 @@ $(function() {
                 var tmpPinOld = $('#sauth-pin-old').val();
                 var tmpPinNew = $('#sauth-pin-new').val();
                 if ((tmpPinNew.length === 4) && (item.pin == tmpPinOld)) {
-                    browser.storage.local.set({ pin: tmpPinNew });
-                    $('#sauth-pin-old').val('');
-                    $('#sauth-pin-new').val('');
-                    alert(browser.i18n.getMessage('SAuthAlertFormPinSuccess'));
+                    browser.storage.local.remove(['pin', 'sessionDate']).then(function(itemDel) {
+                        browser.storage.local.set({ pin: tmpPinNew });
+                        $('#sauth-pin-old').val('');
+                        $('#sauth-pin-new').val('');
+                        alert(browser.i18n.getMessage('SAuthAlertFormPinSuccess'));
+                    });
                 } else {
                     alert(browser.i18n.getMessage('SAuthAlertForm'));
                 }
@@ -104,7 +106,7 @@ $(function() {
                 // update table
                 $('#list-secrets  tbody').html('');
                 $.each(listSecrets, function( key, value ) {
-                    var tmpRow = '<tr><td>' + parseInt(key + 1) + '</td><td>' + value.account + '</td><td>************</td><td class="text-danger text-right"><button class="btn btn-danger delete"></button></td></tr>';
+                    var tmpRow = '<tr><td>' + parseInt(key + 1) + '</td><td>' + value.account + '</td><td data-code="' + value.code + '">************</td><td class="text-danger text-right"><button class="btn btn-danger delete"></button></td></tr>';
                     $('#list-secrets tbody').append(tmpRow);
                 });
                 $('.delete').html(SAuthButtonDelete).on('click', function(){
@@ -126,7 +128,7 @@ $(function() {
             browser.storage.local.get('listSecrets').then(function(item) {
                 var SAuthButtonDelete = browser.i18n.getMessage('SAuthButtonDelete');
                 var tmpAccount = $(rowSecret[0].childNodes[1]).html();
-                var tmpCode = $(rowSecret[0].childNodes[2]).html();
+                var tmpCode = $(rowSecret[0].childNodes[2]).data('code');
                 var newListSecrets = $.grep(item.listSecrets, function( n, i ) {
                     var tmpSupp = { account: tmpAccount, code: tmpCode };
                     return n.code != tmpSupp.code;
@@ -136,7 +138,7 @@ $(function() {
                 // update table
                 $('#list-secrets  tbody').html('');
                 $.each(newListSecrets, function( key, value ) {
-                    var tmpRow = '<tr><td>' + parseInt(key + 1) + '</td><td>' + value.account + '</td><td>************</td><td class="text-danger text-right"><button class="btn btn-danger delete"></button></td></tr>';
+                    var tmpRow = '<tr><td>' + parseInt(key + 1) + '</td><td>' + value.account + '</td><td data-code="' + value.code + '">************</td><td class="text-danger text-right"><button class="btn btn-danger delete"></button></td></tr>';
                     $('#list-secrets tbody').append(tmpRow);
                 });
                 $('.delete').html(SAuthButtonDelete).on('click', function(){
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"manifest_version": 2,
 	"name": "__MSG_SAuthName__",
-	"version": "1.0.1",
+	"version": "1.0.2",
 	"description": "__MSG_SAuthDescription__",
 	"homepage_url": "https://github.com/Silbad/SAuth",
 	"default_locale": "en",
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "SAuth",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "All token secrets for two-factor authentication",
   "main": "index.js",
   "repository": "https://github.com/Silbad/SAuth",

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"manifest_version": 2,`
`3`	`3`	`"name": "__MSG_SAuthName__",`
`4`		`- "version": "1.0.1",`
	`4`	`+ "version": "1.0.2",`
`5`	`5`	`"description": "__MSG_SAuthDescription__",`
`6`	`6`	`"homepage_url": "https://github.com/Silbad/SAuth",`
`7`	`7`	`"default_locale": "en",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "SAuth",`
`3`		`- "version": "1.0.1",`
	`3`	`+ "version": "1.0.2",`
`4`	`4`	`"description": "All token secrets for two-factor authentication",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"repository": "https://github.com/Silbad/SAuth",`