Added extended testing, separated tests and benchmarks #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timized data structs
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
jcarpent
reviewed
Aug 23, 2024
Comment on lines
+9
to
+10
| .cache | ||
| .DS_Store |
There was a problem hiding this comment.
Should be set in your local .gitignore on your computer.
jcarpent
reviewed
Aug 23, 2024
Comment on lines
+88
to
+89
| option(BUILD_WITH_EXTENDED_TESTING "Build library with extended testing" OFF) | ||
| option(BUILD_WITH_BENCHMARK "Build library with timing benchmarks" OFF) |
There was a problem hiding this comment.
Suggested change
| option(BUILD_WITH_EXTENDED_TESTING "Build library with extended testing" OFF) | |
| option(BUILD_WITH_BENCHMARK "Build library with timing benchmarks" OFF) | |
| option(BUILD_EXTENDED_TESTING "Build library with extended testing" OFF) | |
| option(BUILD_BENCHMARK "Build library with timing benchmarks" OFF) |
jcarpent
reviewed
Aug 23, 2024
Comment on lines
+158
to
+165
| # set(LIB_EXTENDED_TEST_DIR ${PROJECT_SOURCE_DIR}/problems) | ||
| # set(LIB_EXTENDED_TEST_HEADERS | ||
| # ${LIB_EXTENDED_TEST_DIR}/test-problems.hpp) | ||
| # set(LIB_EXTENDED_TEST_SOURCES | ||
| # ${LIB_EXTENDED_TEST_DIR}/test-problems.cpp) | ||
| # set(LIB_BENCH_DIR ${PROJECT_SOURCE_DIR}/bench) | ||
| # set(LIB_BENCH_SOURCES | ||
| # ${LIB_BENCH_DIR}/timings.cpp) |
There was a problem hiding this comment.
If not used, should be removed.
jcarpent
reviewed
Aug 23, 2024
Comment on lines
+178
to
+186
| # if(BUILD_WITH_BENCHMARK) | ||
| # list(APPEND LIB_SOURCES ${LIB_BENCH_SOURCES}) | ||
| # endif() | ||
|
|
||
| # if(BUILD_WITH_EXTENDED_TESTING) | ||
| # list(APPEND LIB_HEADERS ${LIB_EXTENDED_TEST_HEADERS}) | ||
| # list(APPEND LIB_SOURCES ${LIB_EXTENDED_TEST_SOURCES}) | ||
| # endif() | ||
|
|
jcarpent
reviewed
Aug 23, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include "fwd.hpp" | |||
There was a problem hiding this comment.
Suggested change
| #include "fwd.hpp" | |
| #include "loik/fwd.hpp" |
jcarpent
reviewed
Aug 23, 2024
Comment on lines
+1
to
+295
|
|
||
| // converged | ||
| problem_struct.converged = problem_sol.get<bool>("converged"); | ||
|
|
||
| // primal_infeasible | ||
| problem_struct.primal_infeasible = problem_sol.get<bool>("primal_infeasible"); | ||
|
|
||
| // dual_infeasible | ||
| problem_struct.dual_infeasible = problem_sol.get<bool>("dual_infeasible"); | ||
|
|
||
| // primal_residual | ||
| problem_struct.primal_residual = problem_sol.get<double>("primal_residual"); | ||
|
|
||
| // dual_residual | ||
| problem_struct.dual_residual = problem_sol.get<double>("dual_residual"); | ||
|
|
||
| // mu | ||
| problem_struct.mu = problem_sol.get<double>("mu"); | ||
|
|
||
| // n_iter | ||
| problem_struct.n_iter = problem_sol.get<int>("n_iter"); | ||
|
|
||
| // n_tail_solve_iter | ||
| problem_struct.n_tail_solve_iter = problem_sol.get<int>("n_tail_solve_iter"); | ||
|
|
||
| // n_active_ineq_constraint | ||
|
|
||
| // vis | ||
| const ptree& vis_pt = problem_sol.get_child("vis"); | ||
| utils::PtreeToContainerOfObj<Motion, pin_aligned_vec>(vis_pt, problem_struct.vis); | ||
|
|
||
| // yis | ||
| const ptree& yis_pt = problem_sol.get_child("yis"); | ||
| utils::PtreeToContainerOfObj<Vec6, pin_aligned_vec>(yis_pt, problem_struct.yis); | ||
|
|
||
| // w | ||
| const ptree& w_pt = problem_sol.get_child("w"); | ||
| utils::PtreeToDataObj<DVec>(w_pt, problem_struct.w); | ||
|
|
||
|
|
||
| // z | ||
| const ptree& z_pt = problem_sol.get_child("z"); | ||
| utils::PtreeToDataObj<DVec>(z_pt, problem_struct.z); | ||
|
|
||
|
|
||
| /// push problem to problem_sequence | ||
| problem_sequence.push_back(problem_struct); | ||
|
|
||
| } //endfor | ||
|
|
||
| } // SequenceDiffIKProblems::LoadProblemsFromJson | ||
|
|
||
|
|
||
| /// explicit instantiation and specializations | ||
| namespace utils { | ||
| using Index = typename loik::DiffIKProblem<double>::Index; | ||
| using DVec = typename loik::DiffIKProblem<double>::DVec; | ||
| using Vec6 = typename loik::DiffIKProblem<double>::Vec6; | ||
| using Motion = typename loik::DiffIKProblem<double>::Motion; | ||
| using Mat6x6 = typename loik::DiffIKProblem<double>::Mat6x6; | ||
|
|
||
| template<typename T> | ||
| using pin_aligned_vec = typename pinocchio::container::aligned_vector<T>; | ||
|
|
||
| // explicit instantiation | ||
| template void PtreeToVec<DVec>(const ptree&, const DVec&); | ||
| template void PtreeToVec<Vec6>(const ptree&, const Vec6&); | ||
| template void PtreeToMat<Mat6x6>(const ptree&, const Mat6x6&); | ||
|
|
||
|
|
||
| // `PtreeToDataObj` specializations | ||
| template <> | ||
| void PtreeToDataObj<DVec>(const ptree& pt, const DVec& vec) { PtreeToVec<DVec>(pt, vec); } // PtreeToDataObj<DVec> | ||
| template <> | ||
| void PtreeToDataObj<Vec6>(const ptree& pt, const Vec6& vec) { PtreeToVec<Vec6>(pt, vec); } // PtreeToDataObj<Vec6> | ||
| template <> | ||
| void PtreeToDataObj<Mat6x6>(const ptree& pt, const Mat6x6& mat) { PtreeToMat<Mat6x6>(pt, mat); } // PtreeToDataObj<Mat6x6> | ||
| template <> | ||
| void PtreeToDataObj<Motion>(const ptree& pt, const Motion& motion) | ||
| { | ||
| Motion& motion_out = const_cast<Motion&>(motion); | ||
| Motion::Vector6 motion_v6 = Motion::Vector6::Zero(); | ||
| PtreeToVec(pt, motion_v6); | ||
| motion_out = motion_v6; | ||
| } // PtreeToDataObj<Motion> | ||
|
|
||
| // explicit instantiation | ||
| template void PtreeToDataObj<Index>(const ptree&, const Index&); | ||
| template void PtreeToContainerOfObj<Index, std::vector>(const ptree&, const std::vector<Index>&); | ||
| template void PtreeToContainerOfObj<DVec, pin_aligned_vec>(const ptree&, const pin_aligned_vec<DVec>&); | ||
| template void PtreeToContainerOfObj<Vec6, pin_aligned_vec>(const ptree&, const pin_aligned_vec<Vec6>&); | ||
| template void PtreeToContainerOfObj<Mat6x6, pin_aligned_vec>(const ptree&, const pin_aligned_vec<Mat6x6>&); | ||
| template void PtreeToContainerOfObj<Motion, pin_aligned_vec>(const ptree&, const pin_aligned_vec<Motion>&); | ||
|
|
||
| } // namespace utils | ||
|
|
||
| template struct DiffIKProblem<double>; | ||
| template struct SequenceDiffIKProblems<double>; | ||
|
|
||
| } // namespace loik |
jcarpent
reviewed
Aug 23, 2024
Comment on lines
+100
to
+101
| // std::string("/panda_description/urdf/panda.urdf"); | ||
| // urdf_filename = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem data JSON files are copied over from IkBench. Now has separate bench compile options