maui: compiled bindings

* Try to resolve all warnings
* Required for AOT

Author: thewizrd

Diff for: Directory.Build.props

@@ -3,6 +3,7 @@
   <PropertyGroup>
     <LangVersion>latest</LangVersion>
     <Version>5.11.0</Version>
+    <Nullable>warnings</Nullable>
     <!-- Version Code Format (.NET Version, App Version, Build Number) -->
     <!-- Note: Update here as well as Maui.AppWidget xproj -->
     <VersionCode Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) != 'windows'">95110000</VersionCode>
@@ -39,6 +40,11 @@
   <!-- Maui -->
   <PropertyGroup>
     <MauiVersion>9.0.40</MauiVersion>
+    <_MauiBindingInterceptorsSupport>true</_MauiBindingInterceptorsSupport>
+    <MauiEnableXamlCBindingWithSourceCompilation>true</MauiEnableXamlCBindingWithSourceCompilation>
+    <MauiStrictXamlCompilation>true</MauiStrictXamlCompilation>
+    <NoWarn Condition="'$(_TargetPlatformIsWindows)' != 'True'">$(NoWarn);MT7091</NoWarn>
+    <WarningsAsErrors Condition="'$(_TargetPlatformIsWindows)' != 'True'">$(WarningsAsErrors);XC0022;XC0023;IL2026</WarningsAsErrors>
   </PropertyGroup>
 
   <PropertyGroup>

Diff for: Maui/SimpleWeather.Maui/Controls/AppBar/AppBarItem.cs

@@ -196,7 +196,7 @@ void UpdateLayout()
                     _appbarItemText.Text = _originalText;
                 else
                 {
-                    if (Device.RuntimePlatform == Device.Android && !string.IsNullOrEmpty(_originalText))
+                    if (DeviceInfo.Platform == DevicePlatform.Android && !string.IsNullOrEmpty(_originalText))
                         _appbarItemText.Text = _originalText.ToUpper();
                 }
             }

Diff for: Maui/SimpleWeather.Maui/Controls/HourlyForecastItem.xaml

@@ -9,7 +9,8 @@
              xmlns:mrkup="clr-namespace:SimpleWeather.Maui.MarkupExtensions"
              WidthRequest="{OnIdiom Default=150, Phone={mrkup:OnDeviceWidth MinWidth=828, Default=90, GreaterThanEq=100}, Tablet=110}"
              HeightRequest="{OnIdiom Default=250, Phone={mrkup:OnDeviceWidth MinWidth=828, Default=200, GreaterThanEq=175}, Tablet=192}"
-             BindingContextChanged="HourlyForecastItem_BindingContextChanged">
+             BindingContextChanged="HourlyForecastItem_BindingContextChanged"
+             x:Name="Control">
     <VerticalStackLayout VerticalOptions="Center">
         <HorizontalStackLayout
             MinimumHeightRequest="20"
@@ -46,7 +47,7 @@
             IconWidth="{OnIdiom Phone=36, Tablet=42, Default=50}"
             Margin="5"
             HorizontalOptions="Center"
-            IconProvider="{Binding Source={RelativeSource AncestorType={x:Type controls:HourlyForecastItem}}, Path=IconProvider}"
+            IconProvider="{Binding Source={x:Reference Control}, Path=IconProvider, x:DataType={x:Type controls:HourlyForecastItem}}"
             WeatherIcon="{Binding Icon}" />
         <Label
             Padding="{OnIdiom Default='10,0', Phone='4'}"

Diff for: Maui/SimpleWeather.Maui/Controls/HourlyForecastItemPanel.xaml

@@ -32,7 +32,7 @@
                 </CollectionView.ItemsLayout>
                 <CollectionView.ItemTemplate>
                     <DataTemplate>
-                        <controls:HourlyForecastItem IconProvider="{Binding Source={RelativeSource AncestorType={x:Type controls:HourlyForecastItemPanel}}, Path=IconProvider, Mode=OneWay}">
+                        <controls:HourlyForecastItem IconProvider="{Binding Source={RelativeSource AncestorType={x:Type controls:HourlyForecastItemPanel}}, Path=IconProvider, Mode=OneWay, x:DataType={x:Type controls:HourlyForecastItemPanel}}">
                             <controls:HourlyForecastItem.GestureRecognizers>
                                 <TapGestureRecognizer Tapped="HourlyItem_Tapped" />
                             </controls:HourlyForecastItem.GestureRecognizers>

Diff for: Maui/SimpleWeather.Maui/Controls/IconControl.cs

@@ -1,4 +1,5 @@
-using CommunityToolkit.Mvvm.DependencyInjection;
+using CommunityToolkit.Maui.Markup;
+using CommunityToolkit.Mvvm.DependencyInjection;
 using SimpleWeather.Icons;
 using SimpleWeather.Preferences;
 using SimpleWeather.SkiaSharp;
@@ -83,7 +84,7 @@ public double IconHeight
         }
 
         public static readonly BindableProperty IconHeightProperty =
-            BindableProperty.Create(nameof(IconHeight), typeof(double), typeof(IconControl), double.NaN, propertyChanged: (obj, _, _) => (obj as IconControl)?.UpdateWeatherIcon());
+            BindableProperty.Create(nameof(IconHeight), typeof(double), typeof(IconControl), -1d, propertyChanged: (obj, _, _) => (obj as IconControl)?.UpdateWeatherIcon());
 
         public double IconWidth
         {
@@ -92,9 +93,9 @@ public double IconWidth
         }
 
         public static readonly BindableProperty IconWidthProperty =
-            BindableProperty.Create(nameof(IconWidth), typeof(double), typeof(IconControl), double.NaN, propertyChanged: (obj, _, _) => (obj as IconControl)?.UpdateWeatherIcon());
+            BindableProperty.Create(nameof(IconWidth), typeof(double), typeof(IconControl), -1d, propertyChanged: (obj, _, _) => (obj as IconControl)?.UpdateWeatherIcon());
 
-        private readonly SettingsManager SettingsManager = Ioc.Default.GetService<SettingsManager>();
+        private readonly SettingsManager _settingsManager = Ioc.Default.GetService<SettingsManager>();
 
         public IconControl()
         {
@@ -124,7 +125,7 @@ public async void UpdateWeatherIcon()
             // Remove any animatable drawables
             RemoveAnimatedDrawables();
 
-            var wip = SharedModule.Instance.WeatherIconsManager.GetIconProvider(IconProvider ?? SettingsManager.IconProvider);
+            var wip = SharedModule.Instance.WeatherIconsManager.GetIconProvider(IconProvider ?? _settingsManager.IconProvider);
 
             if (ForceBitmapIcon)
             {
@@ -188,18 +189,8 @@ public async void UpdateWeatherIcon()
 
                             e.Surface.Flush(true);
                         };
-                        canvas.SetBinding(HeightRequestProperty, new Binding()
-                        {
-                            Source = this,
-                            Path = nameof(IconHeight),
-                            Mode = BindingMode.OneWay,
-                        });
-                        canvas.SetBinding(WidthRequestProperty, new Binding()
-                        {
-                            Source = this,
-                            Path = nameof(IconWidth),
-                            Mode = BindingMode.OneWay,
-                        });
+                        canvas.Bind(HeightRequestProperty, static src => src.IconHeight, mode: BindingMode.OneWay, source: this);
+                        canvas.Bind(WidthRequestProperty, static src => src.IconWidth, mode: BindingMode.OneWay, source: this);
                         iconElement = canvas;
 
                         if (drawable is SKLottieDrawable lottieDrawable)
@@ -244,18 +235,8 @@ public async void UpdateWeatherIcon()
 
                         e.Surface.Flush(true);
                     };
-                    canvas.SetBinding(HeightRequestProperty, new Binding()
-                    {
-                        Source = this,
-                        Path = nameof(IconHeight),
-                        Mode = BindingMode.OneWay,
-                    });
-                    canvas.SetBinding(WidthRequestProperty, new Binding()
-                    {
-                        Source = this,
-                        Path = nameof(IconWidth),
-                        Mode = BindingMode.OneWay,
-                    });
+                    canvas.Bind(HeightRequestProperty, static src => src.IconHeight, mode: BindingMode.OneWay, source: this);
+                    canvas.Bind(WidthRequestProperty, static src => src.IconWidth, mode: BindingMode.OneWay, source: this);
                     iconElement = canvas;
                 }
                 catch (Exception e)
@@ -276,7 +257,7 @@ public async void UpdateWeatherIcon()
 
         private bool ShouldUseBitmap()
         {
-            return ShowAsMonochrome && IconColor != Colors.Transparent && !IsBlackOrWhiteColor(IconColor);
+            return ShowAsMonochrome && !Equals(IconColor, Colors.Transparent) && !IsBlackOrWhiteColor(IconColor);
         }
 
         private bool IsBlackOrWhiteColor(Color c)
@@ -315,18 +296,8 @@ private async Task<IView> CreateBitmapIcon(IWeatherIconsProvider provider)
 
                 e.Surface.Flush(true);
             };
-            canvas.SetBinding(HeightRequestProperty, new Binding()
-            {
-                Source = this,
-                Path = nameof(IconHeight),
-                Mode = BindingMode.OneWay,
-            });
-            canvas.SetBinding(WidthRequestProperty, new Binding()
-            {
-                Source = this,
-                Path = nameof(IconWidth),
-                Mode = BindingMode.OneWay,
-            });
+            canvas.Bind(HeightRequestProperty, static src => src.IconHeight, mode: BindingMode.OneWay, source: this);
+            canvas.Bind(WidthRequestProperty, static src => src.IconWidth, mode: BindingMode.OneWay, source: this);
 
             return canvas;
         }