Skip to content

Issue with multiloader recipe conditions #129

@CodinGlitch

Description

@CodinGlitch

Describe the bug

if a forge mod that has both fabric and forge conditions in a recipe is used with FFAPI, the recipe will be skipped.

Steps to reproduce

  1. install a forge mod with conditions for multiple loaders (simple radio, in this case)
  2. install FFAPI
  3. recipes will be skipped on startup

Logs

https://gist.github.com/CodinGlitch/ef918c07f87fae43feccde829463defe

Additional context

i am the developer for Simple Voice Radio, and was receiving a few reports that recipes weren't loading, so after taking a look it seems like when having both recipe conditions for fabric and forge, the fabric api tries to load the fabric recipe conditions, which aren't registered due to the mod being forge-based.

i realize that changes to the api itself should be kept to a minimum, so there may not be a proper solution that can be made on this end, but i figured i should reach out anyway in case there is any potential action i can take to avoid this issue going forward (a solution would be to do data generation per-loader, though it's not a pretty one)

one of the recipes from my mod contains the following which would cause this issue:

{
  "fabric:load_conditions": [
    {
      "condition": "simpleradio:items_enabled",
      "values": [
        "transceiver"
      ]
    }
  ],
  "forge:condition": {
    "type": "simpleradio:items_enabled",
    "item": "transceiver"
  },
  "neoforge:conditions": [
    {
      "type": "simpleradio:items_enabled",
      "item": "transceiver"
    }
  ],
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions