Check for duplicate extremum collision vertices

Author: mlhoutel

addons/rmsmartshape/shapes/point_array.gd

@@ -45,7 +45,6 @@ var _vertex_cache := PackedVector2Array()
 var _curve := Curve2D.new()
 var _curve_no_control_points := Curve2D.new()
 var _tesselation_cache := PackedVector2Array()
-var _tesselation_distinct_cache := PackedVector2Array()
 var _tess_vertex_mapping := SS2D_TesselationVertexMapping.new()
 
 ## Gets called when points were modified.
@@ -608,22 +607,6 @@ func get_tessellated_points() -> PackedVector2Array:
 	return _tesselation_cache
 
 
-## Returns a PackedVector2Array with all distinct points
-func get_tessellated_distinct_points() -> PackedVector2Array:
-	_tesselation_distinct_cache = []
-
-	_update_cache()
-
-	## Force update if first use of distinct cache
-	var _tesselation_cache_size: int = _tesselation_cache.size()
-	var _tesselation_distinct_cache_size: int = _tesselation_distinct_cache.size()
-
-	if _tesselation_distinct_cache_size - 1 < _tesselation_cache_size:
-		_tesselation_distinct_cache = _tesselation_cache.slice(0, _tesselation_cache_size - 1)
-
-	return _tesselation_distinct_cache
-
-
 func set_tessellation_stages(value: int) -> void:
 	tessellation_stages = value
 	_changed()
@@ -678,9 +661,7 @@ func _update_cache() -> void:
 	if _tesselation_cache.size() >= 2:
 		_tesselation_cache[0] = _curve.get_point_position(0)
 		_tesselation_cache[-1] = _curve.get_point_position(_curve.get_point_count() - 1)
-
-	_tesselation_distinct_cache = _tesselation_cache.slice(0, _tesselation_cache.size() - 1)
-
+	
 	_tess_vertex_mapping.build(_tesselation_cache, _vertex_cache)
 
 	_point_cache_dirty = false

addons/rmsmartshape/shapes/shape.gd

@@ -901,7 +901,7 @@ func _generate_collision_points_precise() -> PackedVector2Array:
 
 
 func _generate_collision_points_fast() -> PackedVector2Array:
-	return _points.get_tessellated_distinct_points()
+	return _points.get_tessellated_points()
 
 
 func bake_collision() -> void:
@@ -919,6 +919,9 @@ func bake_collision() -> void:
 	else:
 		generated_points = _generate_collision_points_precise()
 
+	if generated_points.size() > 1 and generated_points[0] == generated_points[-1]:
+		generated_points = generated_points.slice(0, -1)
+
 	var xform := _collision_polygon_node.get_global_transform().affine_inverse() * get_global_transform()
 	_collision_polygon_node.polygon = xform * generated_points