Will there be a 3.X.X package release containing TIFF fixes? #2994
Unanswered
lucienmaloney
asked this question in
Q&A
Replies: 1 comment 2 replies
-
This actually surprises me. It looks similar to this issue #2877 but we have already backported the fix for that here. #2914 I'm happy to ship a fix but the more time I spend working on V3 the less time I have to actually complete and ship V4. If you would like to debug and investigate a fix against the release/v3.1.x branch, then I'm happy to ship it. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
We were testing image rendering against some of our test set, and noticed one of them - pages.tif (included in the zip below) - was rendering incorrectly.
pages.zip
Iterating over the frames and saving each off as a PNG using the latest ImageSharp package releases (ImageSharp 3.1.11, ImageSharp.Drawing 2.1.7), we got back some sort of grid corruption:
However, then testing with all the latest changes in main cloned from the source repos, the problem was fixed:
Which is awesome! (Although I'm not sure yet what the actual merge that fixed it was. I presume one of these - https://github.com/SixLabors/ImageSharp/issues?q=is%3Aissue%20tif%20state%3Aclosed - but I'd have to dig into it more to find which specific one did it.)
Now on our end, we're just trying to figure out the plan for getting the fix incorporated. We still have a couple months before we need to package up our own code incorporating ImageSharp, and so if there's a minor version fix upcoming that'll include the tiff fixes, we can just wait for that. Otherwise, we'll probably need to clone the repo and cherry-pick out the tiff fixes onto one of the existing 3.1.X release branches. And that's doable, but not ideal in our setup, so if the tiff fixes can be packages in the near future, it would make things a lot simpler for us.
Either way, thank you for the work maintaining and cleaning up these edge case bugs in the decoders!
Beta Was this translation helpful? Give feedback.
All reactions