Snes classic, make device list fail properly if in a bugged connecting state (even after close)

Skarsnik · Skarsnik · commit d20c87aedd8a · 2025-07-16T12:09:53.000+02:00
diff --git a/devices/snesclassicfactory.cpp b/devices/snesclassicfactory.cpp
@@ -441,6 +441,7 @@ bool SNESClassicFactory::asyncListDevices()
     if (socket->state() == QAbstractSocket::ConnectingState)
     {
         sDebug() << "This should not happen, socket already trying to connect";
+        checkFailed(Error::DeviceFactoryError::DFE_SNESCLASSIC_NO_DEVICE);
         return false;
     }
     if (socket->state() == QAbstractSocket::UnconnectedState)
@@ -453,7 +454,7 @@ bool SNESClassicFactory::asyncListDevices()
            sDebug() << "Timeout " << socket->state();
            if (socket->state() == QAbstractSocket::ConnectingState)
            {
-               socket->close();
+               socket->disconnectFromHost();
                this->checkFailed(Error::DeviceFactoryError::DFE_SNESCLASSIC_NO_DEVICE);
            }
         });

Original file line number	Diff line number	Diff line change
`@@ -441,6 +441,7 @@ bool SNESClassicFactory::asyncListDevices()`
`441`	`441`	`if (socket->state() == QAbstractSocket::ConnectingState)`
`442`	`442`	`{`
`443`	`443`	`sDebug() << "This should not happen, socket already trying to connect";`
	`444`	`+ checkFailed(Error::DeviceFactoryError::DFE_SNESCLASSIC_NO_DEVICE);`
`444`	`445`	`return false;`
`445`	`446`	`}`
`446`	`447`	`if (socket->state() == QAbstractSocket::UnconnectedState)`
`@@ -453,7 +454,7 @@ bool SNESClassicFactory::asyncListDevices()`
`453`	`454`	`sDebug() << "Timeout " << socket->state();`
`454`	`455`	`if (socket->state() == QAbstractSocket::ConnectingState)`
`455`	`456`	`{`
`456`		`- socket->close();`
	`457`	`+ socket->disconnectFromHost();`
`457`	`458`	`this->checkFailed(Error::DeviceFactoryError::DFE_SNESCLASSIC_NO_DEVICE);`
`458`	`459`	`}`
`459`	`460`	`});`