Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace runCLI for global atom variable #1

Open
banacorn opened this issue Oct 14, 2017 · 3 comments
Open

Replace runCLI for global atom variable #1

banacorn opened this issue Oct 14, 2017 · 3 comments

Comments

@banacorn
Copy link

I believe it might be the runCLI from jest-cli that is preventing the global variable atom from being injected to the testing scripts.

Mocha have no problem doing this.
@SleepWalker
Copy link
Owner

There is a problem, that jest runs tests in separate processes, so I can't setup global.atom from the factory function. If I'll use runInBand option, then it will fail due to jestjs/jest#3552

I want to try to setup jest using setupFiles. If it will work, than the issue will be resolved

@banacorn, regarding your suggestion, I can't understand what do you suggesting. Do you suggest to replace jest with mocha? Or replace runCLI with run?

@banacorn
Copy link
Author

I'm suggesting that we should replace 'runCLI' with anything (still, by jest) that could make 'global.atom' available, if possible.

@SleepWalker
Copy link
Owner

Yep, I'll try to achieve that. Probably, even this week

@banacorn banacorn mentioned this issue Feb 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@banacorn @SleepWalker