Skip to content

Issue 571 fix annoying notes #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cugarteblair wants to merge 2 commits into from
Closed

Issue 571 fix annoying notes #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e32db3
Fix annoying compiler Notes for "when C++17 is enabled changed to mat…
cugarteblair Feb 3, 2026
4e2ec47
Fix annoying compiler Notes for "when C++17 is enabled changed to mat…
cugarteblair Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions platforms/linux/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ target_compile_options (slideruleLib PUBLIC -Wall) # turn on "all" warnings
target_compile_options (slideruleLib PUBLIC -Wextra) # turn on "extra" warnings
target_compile_options (slideruleLib PUBLIC -Wreorder) # turn on warning for object initializer list order enforcement
target_compile_options (slideruleLib PUBLIC -Wshadow) # turn on warning for inner scope var with same name as outer scope var
target_compile_options (slideruleLib PUBLIC -Wno-psabi) # suppress ABI compatibility notes (e.g., C++17 parameter passing changes)
target_compile_options (slideruleLib PUBLIC "$<$<CONFIG:Debug>:-fstack-protector-all>")
target_compile_definitions (slideruleLib PUBLIC "$<$<CONFIG:Debug>:__no_unload__>") # don't unload dynamic modules when in debug so symbols available to address sanitizer postmortem

Expand Down
4 changes: 2 additions & 2 deletions targets/slideruleearth/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ RELEASE_CFG := -DCMAKE_BUILD_TYPE=Release
RELEASE_CFG += $(COMMON_CFG)

all: ## build the server using the local configuration
make -j8 -C $(SLIDERULE_BUILD_DIR)
make -C $(SLIDERULE_BUILD_DIR) install
@set -o pipefail; make -j8 -C $(SLIDERULE_BUILD_DIR) 2>&1 | grep -v "parameter passing for argument of type.*when C..17 is enabled" || test $$? -eq 141
@set -o pipefail; make -C $(SLIDERULE_BUILD_DIR) install 2>&1 | grep -v "parameter passing for argument of type.*when C..17 is enabled" || test $$? -eq 141

prep: ## create temporary directories needed for build
mkdir -p $(SLIDERULE_BUILD_DIR)
Expand Down
Loading