Skip to content

Remove "auto" wall direction option#6193

Open
vovodroid wants to merge 1 commit intoOrcaSlicer:mainfrom
vovodroid:wall-dir-refactor-pr
Open

Remove "auto" wall direction option#6193
vovodroid wants to merge 1 commit intoOrcaSlicer:mainfrom
vovodroid:wall-dir-refactor-pr

Conversation

@vovodroid
Copy link
Contributor

@vovodroid vovodroid commented Jul 20, 2024

Refactoring of Allow specify wall directions #4156.

Simplify wall direction option. It assists with further wall related development. For example I separated between internal and overhang walls reversing, and added option to print overhangs after internal to improve adhesion while keeping external wall first for outer-inner and inner-outer-inner modes.

  1. Auto mode was removed. Just turn reversing on/off for any direction.
  2. Spiral vase could be printed in any direction.

I hope current direction logic was kept. Let me know if something is missed.

@CristianGTR97
Copy link

very clever

@vovodroid vovodroid force-pushed the wall-dir-refactor-pr branch from 966b99e to 40dd3ac Compare September 9, 2024 07:48
@discip
Copy link
Contributor

discip commented Sep 9, 2024

@vovodroid
Is the unfortunate behavior I mentioned here #6236 (comment) also addressed in this PR?

@vovodroid
Copy link
Contributor Author

No, this PR is only base for other changes addressed in my fork. Probably these changes fix your issue.

@vovodroid vovodroid changed the title Refactor wall direction Remove "auto" wall direction option Oct 9, 2024
@vovodroid vovodroid force-pushed the wall-dir-refactor-pr branch from 0f2636d to c2b304b Compare October 12, 2024 10:42
@vovodroid vovodroid force-pushed the wall-dir-refactor-pr branch from c2b304b to 14eea1d Compare January 10, 2025 20:09
@vovodroid vovodroid force-pushed the wall-dir-refactor-pr branch from 14eea1d to c53e465 Compare January 24, 2025 12:11
@vovodroid
Copy link
Contributor Author

@SoftFever @Noisyfox what do you think about this? I have some more improvements basing on this PR.

@vovodroid
Copy link
Contributor Author

@Noisyfox ?

@Hammerfest
Copy link

For example I separated between internal and overhang walls reversing, and added option to print overhangs after internal

I have experienced this, an overhang printing before the inner making at least that area less structural and rough looking.

As a PR that's approaching a year old, is there a problem preventing it's merging? I notice quite a few pages of merges sitting stale while attention seems to be only given to newer PR.

@vovodroid
Copy link
Contributor Author

is there a problem preventing it's merging?

Waiting for @Noisyfox / @SoftFever )))

@ianalexis ianalexis force-pushed the wall-dir-refactor-pr branch from 014e9bb to 2c60cb1 Compare March 6, 2026 12:39
@ianalexis
Copy link
Collaborator

So, tested and it looks good.
Auto is not really needed but, as you are here (allmost 2 years later XD) can you check this idea #11630

Check this comment #11630 (comment)

@RF47
Copy link
Collaborator

RF47 commented Mar 7, 2026

can you check this idea #11630

done in #12669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants