Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule Idea: Do not use collection initializers with ImmutableArray #9681

Open
Tim-Pohlmann opened this issue Oct 9, 2024 · 1 comment
Labels
Area: C# C# rules related issues. Type: Rule Idea Idea for a rule that has NOT been specified.

Comments

@Tim-Pohlmann
Copy link
Contributor

Using a collection initializer with the ImmutableArray type, causes a NullReferenceException.

_ = new ImmutableArray<string> { "init" }; // NRE

SharpLab

@Tim-Pohlmann Tim-Pohlmann added Area: C# C# rules related issues. Type: Rule Idea Idea for a rule that has NOT been specified. labels Oct 9, 2024
@jilles-sg
Copy link

This NRE is a special case of the fact that the parameterless constructor of ImmutableArray<T> results in an object that throws on most access. Perhaps the new rule can trigger on uses of that constructor instead. If a "null" value of ImmutableArray<T> is needed, I'd say the developer should be explicit and write default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C# C# rules related issues. Type: Rule Idea Idea for a rule that has NOT been specified.
Projects
None yet
Development

No branches or pull requests

2 participants