SLVS-2714 Fix: Certain whitespace changes do not trigger reanalysis (#6530)

Part of SLVS-2604

Author: georgii-borovinskikh-sonarsource

src/Integration.Vsix.UnitTests/SonarLintTagger/TextBufferIssueTrackerTests.cs

@@ -258,20 +258,20 @@ public void UpdateAnalysisState_CriticalException_IsNotSuppressed()
         CreateTextChange("", ""),
         CreateTextChange("\r\n", "\t\nSOMETEXT"),
     ];
-    private static object[][] OnTextBufferChangedOnBackground_UpdatesIfNotWhitespace_Params =>
+    private static object[][] OnTextBufferChangedOnBackground_Updates_Params =>
     [
-        [EmptyAndWhitespaceChanges, false],
-        [NonEmptyChanges, true]
+        [EmptyAndWhitespaceChanges],
+        [NonEmptyChanges]
     ];
-    [DynamicData(nameof(OnTextBufferChangedOnBackground_UpdatesIfNotWhitespace_Params))]
+    [DynamicData(nameof(OnTextBufferChangedOnBackground_Updates_Params))]
     [DataTestMethod]
-    public void OnTextBufferChangedOnBackground_UpdatesIfNotWhitespace(List<ITextChange> changes, bool didUpdate)
+    public void OnTextBufferChangedOnBackground_Updates(List<ITextChange> changes)
     {
         ClearMocks();
         mockedJavascriptDocumentFooJs.TextBuffer.CurrentSnapshot.Version.Changes.Returns(new TestableNormalizedTextChangeCollection(changes));
         RaiseTextBufferChangedOnBackground(currentTextBuffer: mockDocumentTextBuffer, CreateTextSnapshotMock());
 
-        documentTrackerUpdater.Received(didUpdate ? 1 : 0).OnDocumentUpdated(testSubject);
+        documentTrackerUpdater.Received(1).OnDocumentUpdated(testSubject);
         VerifyMetadataNotUpdated();
         VerifyIssueConsumerNotCreated();
         VerifyIssueConsumerNotRemoved();

src/Integration.Vsix/SonarLintTagger/TextBufferIssueTracker.cs

@@ -197,15 +197,5 @@ private void CreateIssueConsumer(FileSnapshot fileSnapshot)
         issueConsumerStorage.Set(FilePath, issueConsumer);
     }
 
-    private void TextBuffer_OnChangedOnBackground(object sender, TextContentChangedEventArgs e)
-    {
-        var normalizedTextChangeCollection = e.Changes;
-
-        if (normalizedTextChangeCollection.All(x => string.IsNullOrWhiteSpace(x.NewText) && string.IsNullOrWhiteSpace(x.OldText)))
-        {
-            return;
-        }
-
-        documentTrackerUpdater.OnDocumentUpdated(this);
-    }
+    private void TextBuffer_OnChangedOnBackground(object sender, TextContentChangedEventArgs e) => documentTrackerUpdater.OnDocumentUpdated(this);
 }