Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store SourceTV in m_vecPlayers #262

Open
Vauff opened this issue Jul 8, 2024 · 0 comments
Open

Store SourceTV in m_vecPlayers #262

Vauff opened this issue Jul 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Vauff
Copy link
Contributor

Vauff commented Jul 8, 2024

Poggu has suggested keeping SourceTV in our players vector for consistency following 892bb8e, this would require adding SourceTV checks everywhere we access ZEPlayer, and an assert when using GetZEPlayer() on SourceTV.

It's worth considering that we'd be very likely to miss adding these checks in future development, as no CS2Fixes servers/developers are even running SourceTV to find these issues (it was broken until today). This may be less of an issue further down the road, if/when more CS2Fixes servers actually start using SourceTV, and report these issues as they appear.

@Vauff Vauff added the enhancement New feature or request label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant