Merge pull request #56 from Space48/S48-2368_SDM-Connectors-Issue-with-Node-fetch

S48 2368 sdm connectors issue with node fetch
Upgrade node fetch
Upgrade nodejs to v20
Add npm publish workflow

Author: ansnaldo

.github/workflows/npm-publish-beta.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: '18.x'
+          node-version: '20.x'
           registry-url: 'https://registry.npmjs.org'
 
       - name: Install dependencies
@@ -32,13 +32,16 @@ jobs:
           # Get the current version from package.json
           CURRENT_VERSION=$(node -p "require('./package.json').version")
           
+          # Generate a timestamp for uniqueness
+          TIMESTAMP=$(date +"%Y%m%d%H%M%S")
+          
           # For PR: use PR number in version
           if [[ "${{ github.event_name }}" == "pull_request" ]]; then
-            BETA_VERSION="$CURRENT_VERSION-beta.pr.${{ github.event.pull_request.number }}"
+            BETA_VERSION="$CURRENT_VERSION-beta.pr.${{ github.event.pull_request.number }}.$TIMESTAMP"
           else
             # For develop: use commit hash
             SHORT_SHA=$(echo ${{ github.sha }} | cut -c1-7)
-            BETA_VERSION="$CURRENT_VERSION-beta.$SHORT_SHA"
+            BETA_VERSION="$CURRENT_VERSION-beta.$SHORT_SHA.$TIMESTAMP"
           fi
           
           # Set output for use in next step
@@ -51,3 +54,22 @@ jobs:
         run: npm publish --tag beta --access public
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+
+      - name: Comment on PR with published version
+        if: github.event_name == 'pull_request'
+        uses: actions/github-script@v6
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const version = process.env.BETA_VERSION;
+            const packageName = '@space48/sdm';
+            const installCmd = `npm install ${packageName}@${version}`;
+            
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: `🚀 Beta version published: **${version}**\n\nYou can install this version with:\n\`\`\`bash\n${installCmd}\n\`\`\``
+            });
+        env:
+          BETA_VERSION: ${{ steps.beta-version.outputs.version }}

.github/workflows/npm-publish.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: '18.x'
+          node-version: '20.x'
           registry-url: 'https://registry.npmjs.org'
 
       - name: Install dependencies
@@ -23,7 +23,48 @@ jobs:
       - name: Build
         run: npm run build
 
+      - name: Get package version
+        id: package-version
+        run: echo "version=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT
+
       - name: Publish to npm
         run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+          
+      - name: Find related PRs and comment
+        uses: actions/github-script@v6
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const version = process.env.PACKAGE_VERSION;
+            const packageName = '@space48/sdm';
+            const installCmd = `npm install ${packageName}@${version}`;
+            
+            // Get the commit message to find PR number
+            const { data: commit } = await github.rest.repos.getCommit({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              ref: context.sha
+            });
+            
+            // Look for PR references in the commit message (like "Merge pull request #123")
+            const prMatch = commit.commit.message.match(/Merge pull request #(\d+)/i);
+            
+            if (prMatch && prMatch[1]) {
+              const prNumber = parseInt(prMatch[1], 10);
+              
+              // Comment on the PR
+              await github.rest.issues.createComment({
+                issue_number: prNumber,
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                body: `🚀 New version published: **${version}**\n\nThis version has been published to npm and is now available.\n\nYou can install it with:\n\`\`\`bash\n${installCmd}\n\`\`\``
+              });
+              
+              console.log(`Commented on PR #${prNumber} about the new release ${version}`);
+            } else {
+              console.log('No PR reference found in the commit message. Skipping comment.');
+            }
+        env:
+          PACKAGE_VERSION: ${{ steps.package-version.outputs.version }}

.gitignore

@@ -4,3 +4,4 @@ node_modules
 .npmrc
 /scratch
 package-lock.json
+/lib

.nvmrc

@@ -0,0 +1 @@
+20

README.md

@@ -26,11 +26,11 @@ packages, you must first configure the @space48 scope in npm.
     npm login --registry=https://npm.pkg.github.com --scope=@space48
     ```
 
-### Enable node 14
+### Enable node 20
 
-sdm uses node 14. Use [nvm](https://github.com/nvm-sh/nvm#installing-and-updating) to enable node 14:
+sdm uses node 20. Use [nvm](https://github.com/nvm-sh/nvm#installing-and-updating) to enable node 20:
 ```bash
-nvm use 14
+nvm use 20
 ```