Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support to more easily change currency symbol/format #120

Open
MaxJ02 opened this issue Sep 17, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@MaxJ02
Copy link

MaxJ02 commented Sep 17, 2024

Support to more easily change currency symbol/format

It would be really nice if there were two variables in the config file where we could pick
1: currency symbol goes before or after price
2: currency symbol

I'm not very experienced in JS so I havent been able to change the currency symbol myself after looking at the code. Any help in the right direction would be greatly appreciated. The main issue is that $ is displayed when I get price alerts.

@MaxJ02 MaxJ02 added the enhancement New feature or request label Sep 17, 2024
@SpikeHD
Copy link
Owner

SpikeHD commented Sep 18, 2024

What country are you viewing products in? Can you give me an example link?

@MaxJ02 MaxJ02 closed this as completed Sep 18, 2024
@MaxJ02
Copy link
Author

MaxJ02 commented Sep 18, 2024

Hi. I really appreciate you taking time to reply to this issue! I accidentaly closed this issue just now, sorry about that.

I'm viewing products in Sweden. links can either look like this if viewed in a browser (using .se instead of .com)
https://www.amazon.se/LEGO-Plommonblomma-Blomsterprydnad-Underh%C3%A5llsfria-10369/dp/B00CALQB1E/?_encoding=UTF8&pd_rd_w=rymRx&content-id=amzn1.sym.02cf8378-4ac3-495a-bb29-abcb3fd080a9&pf_rd_p=02cf8378-4ac3-495a-bb29-abcb3fd080a9&pf_rd_r=4ZDVF09QGTQH8G2AR6V5&pd_rd_wg=WdA5q&pd_rd_r=8f647223-e937-4d58-868d-7e7c0cdc0f3b&ref_=pd_hp_d_btf_dtshoveler

Or if shared through the app they use this format: https://amzn.eu/d/9fKVwY6

Currently I have gotten a price update on an amzn.eu link even though I set the variable to "se" in the config file so both seem to work.

@SpikeHD SpikeHD reopened this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants