Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False warnings when building core-java/server test data #46

Open
alexander-yevsyukov opened this issue Sep 17, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@alexander-yevsyukov
Copy link
Contributor

Here's what I got recently in the console:

* What went wrong:
Execution failed for task ':server:generateTestProto'.
> protoc: stdout: . stderr: Sep 17, 2022 6:14:58 PM io.spine.validate.option.Required checkUsage
  WARNING: The field `spine.test.aggregate.number.RejectNegativeLong.number` has the type INT64 and should not be declared as `(required)`.
  Sep 17, 2022 6:14:58 PM io.spine.validate.option.Required checkUsage
  WARNING: The field `spine.test.server.number.NaturalNumber.value` has the type INT32 and should not be declared as `(required)`.
...

Looking at the NaturalNumber declaration reveals that it's not so:

message NaturalNumber {
    option (entity).kind = ENTITY;

    // Natural number value.
    //
    // Must be greater than or equal to zero.
    int32 value = 1 [(min).value = "0"];
}

We do check that at least one field should be in an entity state type, but it doesn't make it required.

@alexander-yevsyukov alexander-yevsyukov added the bug Something isn't working label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant