Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit naming issue for ErrorProneChecksExtension and ErrorProneChecksPlugin #48

Open
alexander-yevsyukov opened this issue Jun 5, 2021 · 0 comments

Comments

@alexander-yevsyukov
Copy link
Contributor

alexander-yevsyukov commented Jun 5, 2021

It would be better to hide the implementation details (e.g. ErrorProne) in the naming. Also, the extension and plugin look a bit rudimentary, especially assuming a separate class SeverityConfigurer and the presence of defaultChecksSeverity property of the io.spine.tools.mc.java.gradle.Extension.

It would be probably better to have all the model check settings under the modelCompiler like this:

modelCompiler {
     checks {
           defaultSeverity = ERROR;
           useValidatingBuildersSeverity = WARNING;
     }
    ...
}

Please also see this PR comment for more details.

@alexander-yevsyukov alexander-yevsyukov transferred this issue from SpineEventEngine/base Sep 21, 2022
@yevhenii-nadtochii yevhenii-nadtochii changed the title Revisit naming issue for ErrorProneChecksExtension and ErrorProneChecksPlugin Revisit naming issue for ErrorProneChecksExtension and ErrorProneChecksPlugin Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant