False warning for assumed (required)
ID of entity state with the int32
type
#161
Labels
bug
Something isn't working
(required)
ID of entity state with the int32
type
#161
An ID field of an entity state is assumed to be
(required)
. We don't have to declare such a field with the option explicitly.An ID could be of
int32
or other type which could not have the(required)
option because of the nature of the type. If this is such a case, we should not emit the warning to console, but we do. Here's what the build ofcore-java
produces:This happens because the stub entity state used in the
CommandRoutingRejectionTest
is declared like this:Validation should not cause console warnings for IDs being of primitive types.
The issue with the warning text
Another aspect of this issue is the test of the warning message. Now it says:
The text is misleading. The entity state does not have the
(required
option. The field is assumed to be required because it's the convention for entity states that we have. The text of the warning should be updated in the scope of addressing the issue.The text was updated successfully, but these errors were encountered: