Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rules-based codegen validation handle new placeholders in error messages #176

Open
yevhenii-nadtochii opened this issue Dec 27, 2024 · 0 comments

Comments

@yevhenii-nadtochii
Copy link
Contributor

yevhenii-nadtochii commented Dec 27, 2024

Recently, we have upgraded the format of error messages. Now, these messages may contain Kotlin-style placeholders, which are substituted with the actual values when the error is composed.

Now, we need to modify our rules-based codegen to handle these placeholders. Code generators (or separate entity) should generate code, which assembles instances of TemplateString with template string itself and its placeholder values.

Some considerations upon this topic can be found in this Google Sheet.

Make sure the test coverage of error messages is solid. Now, we barely test them. Except for (set_once) option, so take a look on its SetOnceErrorMessageITest for example.

Depends on #177.
Relates with #167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant