Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated message types should implement MessageWithConstraints #52

Open
alexander-yevsyukov opened this issue Oct 6, 2022 · 3 comments
Milestone

Comments

@alexander-yevsyukov
Copy link
Collaborator

... at least for backward compatibility with the code from core-java.

@alexander-yevsyukov
Copy link
Collaborator Author

@armiol, it would partially solve the issue with ”required” INT fields we have in core-java.

If we do this, the checking of command messages would just call validate() once again.

@armiol
Copy link
Collaborator

armiol commented Oct 6, 2022

We have discussed that with @dmdashenkov several weeks ago.

What I proposed is to omit this interface for now, since there is no code which ever uses this interface at runtime.

@armiol
Copy link
Collaborator

armiol commented Oct 6, 2022

Let's discuss this issue vocally tomorrow.

@alexander-yevsyukov alexander-yevsyukov added this to the M1 milestone Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants