Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review validation constraints packaging #62

Open
yuri-sergiichuk opened this issue Apr 25, 2019 · 3 comments
Open

Review validation constraints packaging #62

yuri-sergiichuk opened this issue Apr 25, 2019 · 3 comments
Assignees
Milestone

Comments

@yuri-sergiichuk
Copy link

The io.spine.validate package is getting too big. We should consider making different constraints more pluggable for the possible extension of the validation framework.

Also, by making constraints pluggable, it will be probably possible to move them to separate packages.

@alexander-yevsyukov
Copy link
Collaborator

The io.spine.base package depends on io.spine.validation in a number of places, but this dependency can be avoided with some efforts.

The hardest dependency is made in the proto type Error, which declares the field validation_error:

message Error {
    ...
    // An error indicating that a message did not pass validation.
    validate.ValidationError validation_error = 3;
    ...
}

The rest of the dependencies are implications of this one.

@alexander-yevsyukov
Copy link
Collaborator

@armiol, in the light of introducing Validation as a separate library, do you think we need to address it in the scode of v2.0?

@armiol
Copy link
Collaborator

armiol commented Sep 21, 2022

@alexander-yevsyukov yes, definitely.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Sep 21, 2022
@alexander-yevsyukov alexander-yevsyukov transferred this issue from SpineEventEngine/base Oct 17, 2022
@alexander-yevsyukov alexander-yevsyukov added this to the M1 milestone Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants