Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To do list for Validation #7

Open
1 of 8 tasks
dmdashenkov opened this issue Aug 18, 2021 · 2 comments
Open
1 of 8 tasks

To do list for Validation #7

dmdashenkov opened this issue Aug 18, 2021 · 2 comments
Assignees

Comments

@dmdashenkov
Copy link
Contributor

dmdashenkov commented Aug 18, 2021

In order to catch up with the existing validation mechanisms, this new validation library implementation needs to:

  • Cover all the edge cases with integration tests.
  • Add support for custom error messages defined via the options. This also includes changing the docs for options. See the error message format in rule.proto. Maybe, as a part of this change, we should move validation options from base into this repo.
  • Implement the (is_required) constraint;
  • Implement the (when) constraint;
  • Add support for custom validators written in Java or Kotlin and associated with a proto type on runtime.
  • Stop supporting (validation_for) feature. Use custom validators instead.
  • Implement a Gradle plugin that would configure the default validation behaviour for Java projects;

Post v2.0.0-M1

  • Support JS and Dart.
@dmdashenkov dmdashenkov changed the title To do list To do list for Validation Aug 18, 2021
@alexander-yevsyukov alexander-yevsyukov moved this to 📋 Backlog in Validation 2.0 Sep 22, 2022
@alexander-yevsyukov
Copy link
Collaborator

@armiol, let's discuss this issue and our actions on Monday. It's dated, but still relevant in several items.

@armiol
Copy link
Collaborator

armiol commented Dec 2, 2024

As discussed vocally, the list of our actions will presumably be as follows:

  1. Deprecate and remove the 'external" validation as a feature.
  2. Review the state of the custom error messages once the respective works by @alexander-yevsyukov @yevhenii-nadtochii are done.
  3. Postpone JS/TS/Dart validation until we are feature-complete with JVM.
  4. Close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants