Update to the latest config. Switch to Java 11 in build.gradle.

Author: armiol

.github/workflows/build-on-windows.yml

@@ -20,4 +20,5 @@ jobs:
 
       - name: Build project and run tests
         shell: cmd
-        run: gradlew.bat build --stacktrace
+        # For the reason on `--no-daemon` see https://github.com/actions/cache/issues/454
+        run: gradlew.bat build --stacktrace --no-daemon

.idea/codeStyles/Project.xml

@@ -51,10 +51,14 @@ import io.spine.internal.gradle.applyGitHubPackages
 import io.spine.internal.gradle.applyStandard
 import io.spine.internal.gradle.forceVersions
 import io.spine.internal.gradle.github.pages.updateGitHubPages
+import io.spine.internal.gradle.javac.configureErrorProne
+import io.spine.internal.gradle.javac.configureJavac
 import io.spine.internal.gradle.publish.PublishingRepos
 import io.spine.internal.gradle.report.license.LicenseReporter
 import io.spine.internal.gradle.report.pom.PomGenerator
 import io.spine.internal.gradle.spinePublishing
+import io.spine.internal.gradle.testing.configureLogging
+import io.spine.internal.gradle.testing.registerTestTasks
 import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 
 @Suppress("RemoveRedundantQualifierName") // Cannot use imports here.
@@ -98,7 +102,7 @@ plugins {
     }
     @Suppress("RemoveRedundantQualifierName") // Cannot use imports here.
     io.spine.internal.dependency.ErrorProne.GradlePlugin.apply {
-        id(id) version version
+        id(id)
     }
 }
 
@@ -134,26 +138,32 @@ allprojects {
 }
 
 subprojects {
+
+    val spineBaseVersion: String by extra
+    val spineCoreVersion: String by extra
+
     apply {
         plugin("java-library")
         plugin("kotlin")
         plugin("com.google.protobuf")
         plugin("net.ltgt.errorprone")
         plugin("pmd")
         plugin("maven-publish")
-    }
 
-    apply {
         // Apply custom Kotlin script plugins.
         plugin("pmd-settings")
-        // Apply Groovy-based script plugins.
-        with(Scripts) {
-            from(testOutput(project))
-            from(javacArgs(project))
-        }
     }
 
-    LicenseReporter.generateReportIn(project)
+    tasks {
+        withType<JavaCompile> {
+            configureJavac()
+            configureErrorProne()
+        }
+        withType<Test> {
+            configureLogging()
+        }
+        registerTestTasks()
+    }
 
     with(repositories) {
         applyGitHubPackages("base", rootProject)
@@ -163,19 +173,18 @@ subprojects {
         applyStandard()
     }
 
+    LicenseReporter.generateReportIn(project)
     JavadocConfig.applyTo(project)
-
-    val spineBaseVersion: String by extra
-    val spineCoreVersion: String by extra
-
     updateGitHubPages(spineBaseVersion) {
         allowInternalJavadoc.set(true)
         rootFolder.set(rootDir)
     }
 
+    val javaVersion = JavaVersion.VERSION_11
+
     java {
-        sourceCompatibility = JavaVersion.VERSION_1_8
-        targetCompatibility = JavaVersion.VERSION_1_8
+        sourceCompatibility = javaVersion
+        targetCompatibility = javaVersion
     }
 
     kotlin {
@@ -184,15 +193,14 @@ subprojects {
 
     tasks.withType<KotlinCompile>().configureEach {
         kotlinOptions {
-            jvmTarget = JavaVersion.VERSION_1_8.toString()
+            jvmTarget = javaVersion.toString()
             freeCompilerArgs = listOf("-Xskip-prerelease-check")
         }
     }
 
     dependencies {
         ErrorProne.apply {
             errorprone(core)
-            errorproneJavac(javacPlugin)
         }
 
         Protobuf.libs.forEach { api(it) }

.idea/inspectionProfiles/Project_Default.xml

@@ -48,7 +48,14 @@ repositories {
     mavenCentral()
 }
 
-val jacksonVersion = "2.11.0"
+/**
+ * The version of Jackson used by `buildSrc`.
+ *
+ * Please keep this value in sync. with `io.spine.internal.dependency.Jackson.version`.
+ * It's not a requirement, but would be good in terms of consistency.
+ */
+val jacksonVersion = "2.13.0"
+
 val googleAuthToolVersion = "2.1.2"
 val licenseReportVersion = "2.0"
 val grGitVersion = "3.1.1"
@@ -61,6 +68,16 @@ val grGitVersion = "3.1.1"
  */
 val guavaVersion = "30.1.1-jre"
 
+/**
+ * The version of ErrorProne Gradle plugin.
+ *
+ * Please keep in sync. with `io.spine.internal.dependency.ErrorProne.GradlePlugin.version`.
+ *
+ * @see <a href="https://github.com/tbroyer/gradle-errorprone-plugin/releases">
+ *     Error Prone Gradle Plugin Releases</a>
+ */
+val errorProneVersion = "2.0.2"
+
 dependencies {
     implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-xml:$jacksonVersion")
     implementation("com.google.cloud.artifactregistry:artifactregistry-auth-common:$googleAuthToolVersion") {
@@ -69,4 +86,5 @@ dependencies {
     implementation("com.google.guava:guava:$guavaVersion")
     api("com.github.jk1:gradle-license-report:$licenseReportVersion")
     implementation("org.ajoberstar.grgit:grgit-core:${grGitVersion}")
+    implementation("net.ltgt.gradle:gradle-errorprone-plugin:${errorProneVersion}")
 }

build.gradle.kts

@@ -28,6 +28,9 @@
  * This script configures Java Compiler.
  */
 
+println("`javac-args.gradle` script is deprecated. Please use `JavaCompile.configureJavac()` " +
+        "and `JavaCompile.configureErrorProne()` utilities instead.")
+
 tasks.withType(JavaCompile) {
 
     if (JavaVersion.current() != JavaVersion.VERSION_1_8) {

buildSrc/build.gradle.kts

@@ -24,6 +24,9 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+println("`slow-tests.gradle` script is deprecated. " +
+        "Please use `TaskContainer.registerTestTasks()` instead.")
+
 final def slowTag = 'slow' // See io.spine.testing.SlowTest
 
 task fastTest(type: Test) {

buildSrc/src/main/groovy/javac-args.gradle

@@ -29,6 +29,10 @@
 //
 // testCompile project(path: ":projectWithTests", configuration: 'testArtifacts')
 //
+
+println("`test-artifacts.gradle` script is deprecated. " +
+        "Please use the `Project.exposeTestArtifacts()` utility instead.")
+
 configurations {
     testArtifacts.extendsFrom testRuntime
 }

buildSrc/src/main/groovy/slow-tests.gradle

@@ -33,6 +33,8 @@
  *    of tests and their results.
  */
 
+println("`test-output.gradle` script is deprecated. Please use `Test.configureLogging()` instead.")
+
 tasks.withType(Test).each {
     it.testLogging {
         showStandardStreams = true

buildSrc/src/main/groovy/test-artifacts.gradle

@@ -46,6 +46,13 @@ object ErrorProne {
     // https://github.com/tbroyer/gradle-errorprone-plugin/releases
     object GradlePlugin {
         const val id = "net.ltgt.errorprone"
+        /**
+         * The version of this plugin is already specified in `buildSrc/build.gradle.kts` file.
+         * Thus, when applying the plugin in projects build files, only the [id] should be used.
+         *
+         * When the plugin is used as a library (e.g. in tools), its version and the library
+         * artifacts are of importance.
+         */
         const val version = "2.0.2"
         const val lib = "net.ltgt.gradle:gradle-errorprone-plugin:${version}"
     }

buildSrc/src/main/groovy/test-output.gradle

@@ -28,7 +28,7 @@ package io.spine.internal.dependency
 
 @Suppress("unused")
 object Jackson {
-    private const val version = "2.12.4"
+    private const val version = "2.13.0"
     // https://github.com/FasterXML/jackson-core
     const val core = "com.fasterxml.jackson.core:jackson-core:${version}"
     // https://github.com/FasterXML/jackson-databind

buildSrc/src/main/kotlin/io/spine/internal/dependency/ErrorProne.kt

@@ -30,7 +30,7 @@ package io.spine.internal.dependency
 // https://github.com/Kotlin
 object Kotlin {
     @Suppress("MemberVisibilityCanBePrivate") // used directly from outside
-    const val version      = "1.5.30"
+    const val version      = "1.5.31"
     const val reflect      = "org.jetbrains.kotlin:kotlin-reflect:${version}"
     const val stdLib       = "org.jetbrains.kotlin:kotlin-stdlib:${version}"
     const val stdLibCommon = "org.jetbrains.kotlin:kotlin-stdlib-common:${version}"

buildSrc/src/main/kotlin/io/spine/internal/dependency/Jackson.kt

@@ -31,5 +31,5 @@ package io.spine.internal.gradle
  * `false` otherwise.
  */
 fun String.isSnapshot(): Boolean {
-    return contains("snapshot", true)
+    return contains("snapshot", ignoreCase = true)
 }

buildSrc/src/main/kotlin/io/spine/internal/dependency/Kotlin.kt

@@ -57,9 +57,11 @@ object CheckStyleConfig {
             plugin(CheckstylePlugin::class.java)
         }
 
+        val configDir = project.rootDir.resolve("config/quality/")
+
         with(project.the<CheckstyleExtension>()) {
             toolVersion = CheckStyle.version
-            configFile = project.rootDir.resolve("config/quality/checkstyle.xml")
+            configDirectory.set(configDir)
         }
 
         project.afterEvaluate {

buildSrc/src/main/kotlin/io/spine/internal/gradle/StringExtensions.kt

@@ -0,0 +1,85 @@
+/*
+ * Copyright 2021, TeamDev. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Redistribution and use in source and/or binary forms, with or without
+ * modification, must retain the above copyright notice and the following
+ * disclaimer.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+package io.spine.internal.gradle.javac
+
+import net.ltgt.gradle.errorprone.errorprone
+import org.gradle.api.tasks.compile.JavaCompile
+import org.gradle.process.CommandLineArgumentProvider
+
+/**
+ * Configures Error Prone for this `JavaCompile` task.
+ *
+ * Specifies the arguments for the compiler invocations. In particular, this configuration
+ * overrides a number of Error Prone defaults. See [ErrorProneConfig] for the details.
+ *
+ * Please note that while `ErrorProne` is a standalone Gradle plugin,
+ * it still has to be configured through `JavaCompile` task options.
+ *
+ * Here's an example of how to use it:
+ *
+ * ```
+ * tasks {
+ *     withType<JavaCompile> {
+ *         configureErrorProne()
+ *     }
+ * }
+ *```
+ */
+fun JavaCompile.configureErrorProne() {
+    options.errorprone
+        .errorproneArgumentProviders
+        .add(ErrorProneConfig.ARGUMENTS)
+}
+
+/**
+ * The knowledge that is required to set up `Error Prone`.
+ */
+private object ErrorProneConfig {
+
+    /**
+     * Command line options for the `Error Prone` compiler.
+     */
+    val ARGUMENTS = CommandLineArgumentProvider {
+        listOf(
+
+            // Exclude generated sources from being analyzed by ErrorProne.
+            "-XepExcludedPaths:.*/generated/.*",
+
+            // Turn the check off until ErrorProne can handle `@Nested` JUnit classes.
+            // See issue: https://github.com/google/error-prone/issues/956
+            "-Xep:ClassCanBeStatic:OFF",
+
+            // Turn off checks that report unused methods and method parameters.
+            // See issue: https://github.com/SpineEventEngine/config/issues/61
+            "-Xep:UnusedMethod:OFF",
+            "-Xep:UnusedVariable:OFF",
+
+            "-Xep:CheckReturnValue:OFF",
+            "-Xep:FloggerSplitLogStatement:OFF",
+        )
+    }
+}