added servergroupclientlist cmd

Ref #823

Author: Splamy

TS3AudioBot/MainCommands.cs

@@ -1148,7 +1148,7 @@ public static async Task CommandNext(PlayManager playManager, InvokerData invoke
 		[Command("param", "_undocumented")] // TODO add documentation, when name decided
 		public static async Task<object?> CommandParam(ExecutionInformation info, int index)
 		{
-			if (!info.TryGet<AliasContext>(out var ctx) || ctx.Arguments == null)
+			if (!info.TryGet<AliasContext>(out var ctx) || ctx.Arguments is null)
 				throw new CommandException("No parameter available", CommandExceptionReason.CommandError);
 
 			if (index < 0 || index >= ctx.Arguments.Count)
@@ -1819,7 +1819,7 @@ public static JsonObject CommandWhisperList(IVoiceTarget targetManager)
 					strb.Append(strings.cmd_whisper_list_target_whisper_channel).Append(": [").Append(string.Join(",", x.WhisperChannel)).Append("]");
 					break;
 				case TargetSendMode.WhisperGroup:
-					if (x.GroupWhisper == null) throw new ArgumentNullException();
+					if (x.GroupWhisper is null) throw new ArgumentNullException();
 					strb.AppendFormat(strings.cmd_whisper_list_target_whispergroup, x.GroupWhisper.Type, x.GroupWhisper.Target, x.GroupWhisper.TargetId);
 					break;
 				default:

TS3AudioBot/ResourceFactories/AudioResource.cs

@@ -55,7 +55,7 @@ public AudioResource Add(string key, string value)
 
 		public string? Get(string key)
 		{
-			if (AdditionalData == null)
+			if (AdditionalData is null)
 				return null;
 			return AdditionalData.TryGetValue(key, out var value) ? value : null;
 		}

TS3AudioBot/Ts3Client.cs

@@ -196,7 +196,7 @@ public async Task Disconnect()
 
 		private void UpdateIndentityToSecurityLevel(int targetLevel)
 		{
-			if (identity == null) throw new InvalidOperationException();
+			if (identity is null) throw new InvalidOperationException();
 			if (TsCrypt.GetSecurityLevel(identity) < targetLevel)
 			{
 				Log.Info("Calculating up to required security level: {0}", targetLevel);
@@ -249,7 +249,7 @@ public async Task<ClientList> GetClientByName(string name)
 			await RefreshClientBuffer(false);
 			var client = Filter.DefaultFilter.Filter(
 				clientbuffer.Select(cb => new KeyValuePair<string, ClientList>(cb.Name, cb)), name).FirstOrDefault().Value;
-			if (client == null)
+			if (client is null)
 				throw new CommandException(strings.error_ts_no_client_found);
 			return client;
 		}
@@ -621,7 +621,7 @@ private bool AloneRecheckRequired(ClientId clientId, ChannelId channelId)
 		private async ValueTask IsAloneRecheck()
 		{
 			var self = ts3FullClient.Book.Self();
-			if (self == null)
+			if (self is null)
 				return;
 			var ownChannel = self.Channel;
 			ownChannelClients = ts3FullClient.Book.Clients.Values.Where(c => c.Channel == ownChannel && c != self).Select(c => c.Id).ToArray();

TS3AudioBot/Web/Api/WebApi.cs

@@ -114,7 +114,7 @@ public async Task ProcessApiV1Call(HttpContext context)
 				Thread.CurrentThread.CurrentUICulture = CultureInfo.InvariantCulture;
 				var res = await command.Execute(execInfo, Array.Empty<ICommand>());
 
-				if (res == null)
+				if (res is null)
 				{
 					response.StatusCode = (int)HttpStatusCode.NoContent;
 				}

TSLib/Commands/TsCommand.cs

@@ -48,10 +48,12 @@ public TsCommand(string command, ICollection<ICommandPart> parameter) : this(com
 		}
 
 		[DebuggerStepThrough]
-		public virtual TsCommand Add(ICommandPart addParameter)
+		public virtual TsCommand Add(ICommandPart? addParameter)
 		{
+			if (addParameter is null)
+				return this;
 			raw = null;
-			if (parameter == null)
+			if (parameter is null)
 				parameter = new List<ICommandPart>();
 			else if (parameter.IsReadOnly)
 				parameter = new List<ICommandPart>(parameter);

TSLib/Commands/TsCommand.gen.tt

@@ -17,7 +17,7 @@
 <#
 // "TimeSpan" (Currently removed, as it is too ambiguous)
 var types = new [] {"bool", "sbyte", "byte", "short", "ushort", "int", "uint", "long", "ulong", "float", "double", "string", "DateTime" };
-var aliasTypes = new [] { "Uid",  "ClientDbId", "ClientId", "ChannelId", "ServerGroupId", "ChannelGroupId"};
+var aliasTypes = new [] { "Uid",  "ClientDbId", "ClientId", "ChannelId", "ServerGroupId", "ChannelGroupId" };
 var classTypes = new [] { "string" };
 #>
 

TSLib/Full/Book/Book.cs

@@ -23,7 +23,7 @@ public partial class Connection
 		public Channel? CurrentChannel()
 		{
 			var self = Self();
-			if (self == null)
+			if (self is null)
 				return null;
 			return GetChannel(self.Channel);
 		}

TSLib/TsBaseFunctions.cs

@@ -423,6 +423,13 @@ public Task<R<ServerConnectionInfo, CommandError>> GetServerConnectionInfo()
 			=> SendHybrid<ServerConnectionInfo>(new TsCommand("serverrequestconnectioninfo"),
 				NotificationType.ServerConnectionInfo).MapToSingle();
 
+		public Task<R<ServerGroupClientList[], CommandError>> ServerGroupClientList(ServerGroupId serverGroupId, bool getNames = false)
+			=> SendHybrid<ServerGroupClientList>(new TsCommand("servergroupclientlist")
+			{
+				{ "sgid", serverGroupId },
+				{ getNames ? new CommandOption("names") : null }
+			}, NotificationType.ServerGroupClientList);
+
 		#endregion
 	}
 }