Global upgrade of the dev dependencies + PHP8.4 tests (#60)

Author: Spomky

.github/workflows/integrate.yml

@@ -57,6 +57,7 @@ jobs:
           - "8.1"
           - "8.2"
           - "8.3"
+          - "8.4"
         dependencies:
           - "lowest"
           - "highest"

composer.json

@@ -56,18 +56,16 @@
     "require-dev": {
         "ext-gmp": "*",
         "ext-openssl": "*",
-        "ekino/phpstan-banned-code": "^1.0",
-        "infection/infection": "^0.28",
+        "ekino/phpstan-banned-code": "^1.0|^2.0|^3.0",
+        "infection/infection": "^0.28|^0.29",
         "php-parallel-lint/php-parallel-lint": "^1.3",
-        "phpstan/extension-installer": "^1.3",
-        "phpstan/phpstan": "^1.8",
-        "phpstan/phpstan-beberlei-assert": "^1.0",
-        "phpstan/phpstan-deprecation-rules": "^1.0",
-        "phpstan/phpstan-phpunit": "^1.1",
-        "phpstan/phpstan-strict-rules": "^1.3",
-        "rector/rector": "^1.0",
+        "phpstan/extension-installer": "^1.3|^2.0",
+        "phpstan/phpstan": "^1.8|^2.0",
+        "phpstan/phpstan-deprecation-rules": "^1.0|^2.0",
+        "phpstan/phpstan-phpunit": "^1.1|^2.0",
+        "phpstan/phpstan-strict-rules": "^1.3|^2.0",
+        "rector/rector": "^1.0|^2.0",
         "roave/security-advisories": "dev-latest",
-        "symfony/phpunit-bridge": "^6.4|^7.0",
         "symfony/string": "^6.4|^7.0",
         "symfony/var-dumper": "^6.4|^7.0",
         "symplify/easy-coding-standard": "^12.0",

phpstan-baseline.neon

@@ -2,8 +2,6 @@ parameters:
 	level: max
 	paths:
 		- src
-	checkMissingIterableValueType: true
-	checkGenericClassInNonGenericObjectType: true
 	checkUninitializedProperties: true
 	treatPhpDocTypesAsCertain: false
 includes:

phpstan.neon

@@ -35,13 +35,9 @@
         </include>
     </source>
     <php>
-        <ini name="display_errors" value="1"/>
         <ini name="error_reporting" value="-1"/>
-        <ini name="memory_limit" value="-1"/>
-        <server name="APP_ENV" value="test" force="true"/>
+        <ini name="xdebug.show_exception_trace" value="0"/>
+        <ini name="display_errors" value="1"/>
         <server name="SHELL_VERBOSITY" value="-1"/>
-        <server name="SYMFONY_PHPUNIT_REMOVE" value=""/>
-        <server name="SYMFONY_PHPUNIT_VERSION" value="10"/>
-        <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak"/>
     </php>
 </phpunit>

phpunit.xml.dist

@@ -6,28 +6,23 @@
 use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
 use Rector\PHPUnit\CodeQuality\Rector\ClassMethod\DataProviderArrayItemsNewLinedRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
-use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
 use Rector\Symfony\Set\SymfonySetList;
-use Rector\Symfony\Symfony42\Rector\New_\StringToArrayArgumentProcessRector;
 use Rector\ValueObject\PhpVersion;
 
 return static function (RectorConfig $config): void {
     $config->import(SetList::DEAD_CODE);
-    $config->import(LevelSetList::UP_TO_PHP_81);
+    $config->import(SetList::PHP_81);
     $config->import(SymfonySetList::SYMFONY_50_TYPES);
-    $config->import(SymfonySetList::SYMFONY_52_VALIDATOR_ATTRIBUTES);
     $config->import(SymfonySetList::SYMFONY_CODE_QUALITY);
     $config->import(SymfonySetList::SYMFONY_CONSTRUCTOR_INJECTION);
-    $config->import(SymfonySetList::ANNOTATIONS_TO_ATTRIBUTES);
     $config->import(PHPUnitSetList::PHPUNIT_CODE_QUALITY);
     $config->import(PHPUnitSetList::ANNOTATIONS_TO_ATTRIBUTES);
     $config->paths([__DIR__ . '/src', __DIR__ . '/tests', __DIR__ . '/ecs.php', __DIR__ . '/rector.php']);
-    $config->skip([
-        DataProviderArrayItemsNewLinedRector::class,
-        PreferPHPUnitThisCallRector::class,
-        StringToArrayArgumentProcessRector::class => [__DIR__ . '/tests'],
-    ]);
+    $config->skip([DataProviderArrayItemsNewLinedRector::class, PreferPHPUnitThisCallRector::class]);
+    $config::configure()->withComposerBased(twig: true, phpunit: true);
+    $config::configure()->withPhpSets();
+    $config::configure()->withAttributesSets();
     $config->phpVersion(PhpVersion::PHP_81);
     $config->parallel();
     $config->importNames();

rector.php

@@ -13,6 +13,7 @@
 use function count;
 use function mb_strlen;
 use function ord;
+use function sprintf;
 
 /**
  * Class to represent BER/DER length octets.

src/ASN1/Component/Length.php

@@ -46,6 +46,7 @@
 use UnexpectedValueException;
 use function array_key_exists;
 use function mb_strlen;
+use function sprintf;
 
 /**
  * Base class for all ASN.1 type elements.

src/ASN1/Element.php

@@ -7,6 +7,7 @@
 use InvalidArgumentException;
 use SpomkyLabs\Pki\ASN1\Element;
 use Stringable;
+use function sprintf;
 
 /**
  * Base class for all string types.

src/ASN1/Type/BaseString.php

@@ -34,15 +34,15 @@ final class GeneralizedTime extends BaseTime
      * @var string
      */
     final public const REGEX = '#^' .
-    '(\d\d\d\d)' . // YYYY
-    '(\d\d)' . // MM
-    '(\d\d)' . // DD
-    '(\d\d)' . // hh
-    '(\d\d)' . // mm
-    '(\d\d)' . // ss
-    '(?:\.(\d+))?' . // frac
-    'Z' . // TZ
-    '$#';
+        '(\d\d\d\d)' . // YYYY
+        '(\d\d)' . // MM
+        '(\d\d)' . // DD
+        '(\d\d)' . // hh
+        '(\d\d)' . // mm
+        '(\d\d)' . // ss
+        '(?:\.(\d+))?' . // frac
+        'Z' . // TZ
+        '$#';
 
     /**
      * Cached formatted date.