Refactor method signatures to include return types in tests and classes (#71)

Author: Spomky

phpstan-baseline.neon

@@ -182,10 +182,7 @@ public function withoutElement(int $idx): self
     public function elements(): array
     {
         if (! isset($this->unspecifiedTypes)) {
-            $this->unspecifiedTypes = array_map(
-                static fn (Element $el) => UnspecifiedType::create($el),
-                $this->elements
-            );
+            $this->unspecifiedTypes = array_map(UnspecifiedType::create(...), $this->elements);
         }
         return $this->unspecifiedTypes;
     }

src/ASN1/Type/Structure.php

@@ -282,7 +282,7 @@ public function namedCurve(): string
     /**
      * @return ObjectIdentifier
      */
-    protected function paramsASN1(): ?Element
+    protected function paramsASN1(): Element
     {
         return ObjectIdentifier::create($this->namedCurve);
     }

src/CryptoTypes/AlgorithmIdentifier/Asymmetric/ECPublicKeyAlgorithmIdentifier.php

@@ -55,7 +55,7 @@ public static function fromASN1Params(?UnspecifiedType $params = null): Specific
     /**
      * @return NullType
      */
-    protected function paramsASN1(): ?Element
+    protected function paramsASN1(): Element
     {
         return NullType::create();
     }

src/CryptoTypes/AlgorithmIdentifier/Asymmetric/RSAEncryptionAlgorithmIdentifier.php

@@ -55,7 +55,7 @@ public static function fromASN1Params(?UnspecifiedType $params = null): Specific
     /**
      * @return NullType
      */
-    protected function paramsASN1(): ?Element
+    protected function paramsASN1(): Element
     {
         return NullType::create();
     }

src/CryptoTypes/AlgorithmIdentifier/Asymmetric/RSAPSSSSAEncryptionAlgorithmIdentifier.php

@@ -75,7 +75,7 @@ public function ivSize(): int
     /**
      * @return OctetString
      */
-    protected function paramsASN1(): ?Element
+    protected function paramsASN1(): Element
     {
         if (! isset($this->initializationVector)) {
             throw new LogicException('IV not set.');

src/CryptoTypes/AlgorithmIdentifier/Cipher/DESCBCAlgorithmIdentifier.php

@@ -76,7 +76,7 @@ public function ivSize(): int
     /**
      * @return OctetString
      */
-    protected function paramsASN1(): ?Element
+    protected function paramsASN1(): Element
     {
         if (! isset($this->initializationVector)) {
             throw new LogicException('IV not set.');

src/CryptoTypes/AlgorithmIdentifier/Cipher/DESEDE3CBCAlgorithmIdentifier.php

@@ -167,7 +167,7 @@ public function ivSize(): int
     /**
      * @return Sequence
      */
-    protected function paramsASN1(): ?Element
+    protected function paramsASN1(): Element
     {
         if ($this->effectiveKeyBits >= 256) {
             $version = $this->effectiveKeyBits;

src/CryptoTypes/AlgorithmIdentifier/Cipher/RC2CBCAlgorithmIdentifier.php

@@ -116,7 +116,7 @@ public function ECPoint(): string
      */
     public function curvePoint(): array
     {
-        return array_map(static fn ($str) => ECConversion::octetsToNumber($str), $this->curvePointOctets());
+        return array_map(ECConversion::octetsToNumber(...), $this->curvePointOctets());
     }
 
     /**

src/CryptoTypes/Asymmetric/EC/ECPublicKey.php

@@ -21,10 +21,6 @@ final class RSASignature extends Signature
      */
     private ?string $_signature = null;
 
-    protected function __construct()
-    {
-    }
-
     /**
      * Initialize from RSA signature *S*.
      *