Merge pull request #124 from Watson1978/fix-leak

SpringMT · web-flow · commit 20f4b8cce99b · 2025-12-24T00:13:42.000+09:00
Fix potential memory leak if zstd_compress fails
diff --git a/ext/zstdruby/zstdruby.c b/ext/zstdruby/zstdruby.c
@@ -30,12 +30,12 @@ static VALUE rb_compress(int argc, VALUE *argv, VALUE self)
   char* output_data = RSTRING_PTR(output);
 
   size_t const ret = zstd_compress(ctx, output_data, max_compressed_size, input_data, input_size, false);
+  ZSTD_freeCCtx(ctx);
   if (ZSTD_isError(ret)) {
     rb_raise(rb_eRuntimeError, "compress error error code: %s", ZSTD_getErrorName(ret));
   }
   rb_str_resize(output, ret);
 
-  ZSTD_freeCCtx(ctx);
   return output;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -30,12 +30,12 @@ static VALUE rb_compress(int argc, VALUE *argv, VALUE self)`
`30`	`30`	`char* output_data = RSTRING_PTR(output);`
`31`	`31`
`32`	`32`	`size_t const ret = zstd_compress(ctx, output_data, max_compressed_size, input_data, input_size, false);`
	`33`	`+ ZSTD_freeCCtx(ctx);`
`33`	`34`	`if (ZSTD_isError(ret)) {`
`34`	`35`	`rb_raise(rb_eRuntimeError, "compress error error code: %s", ZSTD_getErrorName(ret));`
`35`	`36`	`}`
`36`	`37`	`rb_str_resize(output, ret);`
`37`	`38`
`38`		`- ZSTD_freeCCtx(ctx);`
`39`	`39`	`return output;`
`40`	`40`	`}`
`41`	`41`