Skip to content

Commit eaba84f

Browse files
authored
Merge pull request #1440 from garberg/fix_hadolint
Handle some Hadolint errors
2 parents 6fe0614 + 362cbbe commit eaba84f

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,16 @@ jobs:
189189
- name: "Hadolint nipapd"
190190
uses: hadolint/[email protected]
191191
with:
192-
Dockerfile: Dockerfile.nipapd
192+
dockerfile: Dockerfile.nipapd
193+
failure-threshold: warning
194+
override-info: DL3013
193195

194196
- name: "Hadolint WWW"
195197
uses: hadolint/[email protected]
196198
with:
197-
Dockerfile: Dockerfile.www
199+
dockerfile: Dockerfile.www
200+
failure-threshold: warning
201+
override-info: DL3013
198202

199203
- name: "nipapd metadata"
200204
id: nipapd_meta

Dockerfile.nipapd

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333
#
3434

3535
FROM ubuntu:noble
36-
MAINTAINER Kristian Larsson <[email protected]>
36+
37+
LABEL org.opencontainers.image.authors="Kristian Larsson <[email protected]>, Lukas Garberg <[email protected]>"
3738

3839
ENV DEBIAN_FRONTEND=noninteractive
3940

Dockerfile.www

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
FROM ubuntu:noble
2727

28-
MAINTAINER Lukas Garberg <[email protected]>
28+
LABEL org.opencontainers.image.authors="Kristian Larsson <[email protected]>, Lukas Garberg <[email protected]>"
2929

3030
ENV DEBIAN_FRONTEND=noninteractive
3131

@@ -63,11 +63,10 @@ ENV REQUESTS_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt
6363
COPY pynipap /pynipap
6464
COPY nipap /nipap
6565
COPY nipap-www /nipap-www
66-
RUN cd /pynipap && pip3 --no-input install --break-system-packages --no-cache-dir . && \
67-
cd /nipap && pip3 --no-input install --break-system-packages --no-cache-dir . && \
68-
cd /nipap-www && pip3 --no-input install --break-system-packages --no-cache-dir . && \
69-
mkdir -p /etc/nipap/www/ && cp nipap-www.wsgi /etc/nipap/www/ && \
70-
cd ..
66+
RUN pip3 --no-input install --break-system-packages --no-cache-dir ./pynipap/ && \
67+
pip3 --no-input install --break-system-packages --no-cache-dir ./nipap/ && \
68+
pip3 --no-input install --break-system-packages --no-cache-dir ./nipap-www/ && \
69+
mkdir -p /etc/nipap/www/ && cp ./nipap-www/nipap-www.wsgi /etc/nipap/www/
7170

7271
EXPOSE 80
7372
VOLUME [ "/var/log/apache2" ]

0 commit comments

Comments
 (0)