Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mentions in titles of embeds #72

Open
TylerBloom opened this issue Mar 5, 2023 · 0 comments
Open

[Bug]: Mentions in titles of embeds #72

TylerBloom opened this issue Mar 5, 2023 · 0 comments
Labels
bug Something isn't working todo Will be resolved but work hasn't started

Comments

@TylerBloom
Copy link
Member

TylerBloom commented Mar 5, 2023

What went wrong:

Currently, SB almost exclusively uses mentions to refer to players. This is fine most of the time, but fails when the name is in the title of an embed, see the attached picture.

Expected behavior:

The player's name is shown, not their raw mention string.

Solution

Any reference to a player's mention in the title of embeds should be replaced with a call to get their name, not mention.

image.png

@TylerBloom TylerBloom added bug Something isn't working todo Will be resolved but work hasn't started labels Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working todo Will be resolved but work hasn't started
Projects
None yet
Development

No branches or pull requests

1 participant