Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose parameter is not handled in MaskablePPO evaluation. #96

Closed
BurakDmb opened this issue Aug 14, 2022 · 0 comments · Fixed by #97
Closed

Verbose parameter is not handled in MaskablePPO evaluation. #96

BurakDmb opened this issue Aug 14, 2022 · 0 comments · Fixed by #97

Comments

@BurakDmb
Copy link
Contributor

Describe the bug
In the MaskablePPO, MaskableEvalCallback does not handles the verbose parameter. With this issue and the following PR, I suggest passing the self.verbose variable into this constructor.

This issue is created after @qgallouedec 's suggestion in DLR-RM/stable-baselines3#1011 (comment)

eval_callback = MaskableEvalCallback(
eval_env,
best_model_save_path=log_path,
log_path=log_path,
eval_freq=eval_freq,
n_eval_episodes=n_eval_episodes,
use_masking=use_masking,
)
callback = CallbackList([callback, eval_callback])

System Info

({'OS': 'Linux-5.13.0-40-generic-x86_64-with-glibc2.17 #45~20.04.1-Ubuntu SMP Mon Apr 4 09:38:31 UTC 2022', 'Python': '3.8.13', 'Stable-Baselines3': '1.6.1a0', 'PyTorch': '1.11.0', 'GPU Enabled': 'True', 'Numpy': '1.22.3', 'Gym': '0.25.0'}, 'OS: Linux-5.13.0-40-generic-x86_64-with-glibc2.17 #45~20.04.1-Ubuntu SMP Mon Apr 4 09:38:31 UTC 2022\nPython: 3.8.13\nStable-Baselines3: 1.6.1a0\nPyTorch: 1.11.0\nGPU Enabled: True\nNumpy: 1.22.3\nGym: 0.25.0\n')

BurakDmb added a commit to BurakDmb/stable-baselines3-contrib that referenced this issue Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant