Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image popover steals cursor focus #122

Open
b-kelly opened this issue May 4, 2022 · 0 comments · May be fixed by #148
Open

Image popover steals cursor focus #122

b-kelly opened this issue May 4, 2022 · 0 comments · May be fixed by #148
Labels
bug Something isn't working good first issue Good for newcomers mode - rich text Affects the editor's rich text (wysiwyg) mode
Milestone
Beta 3

Comments

@b-kelly
Copy link
Collaborator

b-kelly commented May 4, 2022

Describe the bug
When using the arrow keys to move through a document the image popover "steals" the cursor focus from the document when the image is considered "selected".

To Reproduce
Steps to reproduce the behavior:

  1. Open the default demo page
  2. Place the cursor near the Kermit gif
  3. Use the arrow left/right keys to move the cursor past the image
  4. Note that as soon as the image is focused, the cursor moves to the popover and cannot leave

Expected behavior
The cursor should continue moving through/past the image with out focus being stolen. Ideally, focus would only be stolen when clicking on the image directly.
@b-kelly b-kelly added bug Something isn't working good first issue Good for newcomers mode - rich text Affects the editor's rich text (wysiwyg) mode labels May 4, 2022
@b-kelly b-kelly added this to the Beta 2 milestone May 4, 2022
@b-kelly b-kelly moved this to Todo in Stacks-Editor May 4, 2022
@b-kelly b-kelly mentioned this issue May 4, 2022
Merged
@b-kelly b-kelly modified the milestones: Beta 2, Beta 3 Jun 27, 2022
@colombo15 colombo15 linked a pull request Jun 29, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers mode - rich text Affects the editor's rich text (wysiwyg) mode
Projects
Stacks-Editor
Status: Todo
Milestone
Beta 3
Development

Successfully merging a pull request may close this issue.

fix: Image popover steals cursor focus colombo15/Stacks-Editor
1 participant
@b-kelly