Skip to content

Assertions not raising exceptions when they should. #129

@Mierdin

Description

@Mierdin

Whenever we make assertions with the actions in the asserts pack, the decision of whether or not to move forward seems to be based purely on the success or failure of the action. While there are some cases where the action will raise an Exception and fail, it seems that these assertion actions aren't really built to fail when the assertion is invalid.

For instance,

refers to asserts.object_key_string_equals, and on-success, continues with the workflow. However, the action code doesn't raise an exception when the value isn't equal to the input parameters, it only prints a string.

Since our workflows seem to use these assertions in a success/failed sense, it seems like our assertions currently don't prove anything at all, unless I'm missing something. We should update the action code to raise exceptions to properly trigger failures when applicable, so these workflows work as intended.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions