Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Concurrency Checking #49

Open
2 of 24 tasks
PSchmiedmayer opened this issue Mar 29, 2024 · 0 comments
Open
2 of 24 tasks

Complete Concurrency Checking #49

PSchmiedmayer opened this issue Mar 29, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@PSchmiedmayer
Copy link
Member

PSchmiedmayer commented Mar 29, 2024

Problem

With Swift 6 approaching in a few months and nightly builds already being available we should ensure that all our packages are working well with all Swift concurrency checks.

The goal would be to support Swift 6 right from the start.
We should consider selectively making some of our packages Swift 6 exclusive in case we require features only available in the next major version but should ideally support Swift 5.10 while Swift 6 adoption is picking up.

Solution

Each Spezi Package should enable strict concurrency checking in a PR and ensure that we don't have any warnings remaining in the packages as we develop new features or fix bugs from now. All UI test apps in the projects need to enable these flags by default.

In a final step, the Spezi Template Application and Spezi Study Application should enable strict concurrency checking to demonstrate that we fully support it in using applications.

Additional context

We should consider adding SWIFT_TREAT_WARNINGS_AS_ERRORS = YES to our general workflows to enforce that all warnings are flagged as errors during our CI setup.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Next Steps
Development

No branches or pull requests

1 participant