Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Table of Contents for tabs #78

Open
gbeine opened this issue Jan 10, 2023 · 5 comments
Open

Missing Table of Contents for tabs #78

gbeine opened this issue Jan 10, 2023 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@gbeine
Copy link

gbeine commented Jan 10, 2023

Is there a way to enable the TOC for the selected tab?
Maybe, it's a layer 8 problem, but I'm not able to display a TOC on any tab on pages where I use TabberNeue.

@alistair3149
Copy link
Member

Would you mind to expand a bit on the issue?

@pencildragon
Copy link

Hi there, not OP, but I found this ticket when searching for a solution to the same problem (or at least a related issue).

On pages where I have the Citizen skin enabled and have tabs from TabberNeue, the Table of Contents displays a blank entry even though there are more than three headers in a given tab. The "Contents" title still appears and floats with the article body text as normal, but it is empty. I have checked for conflicting extensions but have not seen anything immediately obvious for conflicts, and this persists even if I append TOC to an article to try and "force" it to load the Table of Contents.

This can be contrasted with pages that do not have a table of contents normally (i.e. fewer than 3 header sections) where the table of contents correctly does not appear at all (blank or otherwise).

My wiki is on MediaWiki 1.39.

image

@alistair3149
Copy link
Member

@pencildragon do you have a demo page with the issue? It is difficult to debug this without a live demo since it involves multiple extensions/skins. TOC generation is decided by MediaWiki core and Citizen takes the data from core to generate a TOC. I'm not sure how MW core interacts with Tabber to get data for the TOC since I can't reproduce this.

@pencildragon
Copy link

@alistair3149 Thanks for the quick reply. I have made a demo page here for you to investigate. You can see it tries to create the table of contents, but then it fails to populate it.

https://chronostars.com/wiki/Demo has tabs.
https://chronostars.com/wiki/Demo/NoTabs has... no tabs, but the content is otherwise the same.

@alistair3149
Copy link
Member

This will take some time to look into since I am not familiar with how MediaWiki core handles ToC currently.
I would appreciate a lot if there is someone who has additional insights!

@alistair3149 alistair3149 added bug Something isn't working help wanted Extra attention is needed labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants