[BugFix] fix the privilege issue DROP STATS command (backport #55695) (#55776)

Co-authored-by: Murphy <[email protected]>

Author: mergify[bot]

fe/fe-core/src/main/java/com/starrocks/load/DeleteMgr.java

@@ -303,8 +303,11 @@ private List<String> partitionPruneForDelete(DeleteStmt stmt, OlapTable table) {
         String predicate = stmt.getWherePredicate().toSql();
         String fakeSql = String.format("SELECT * FROM %s WHERE %s", tableName, predicate);
         PhysicalOlapScanOperator physicalOlapScanOperator;
+        ConnectContext currentSession = ConnectContext.get();
         try {
-            List<StatementBase> parse = SqlParser.parse(fakeSql, ConnectContext.get().getSessionVariable());
+            // Bypass the privilege check, as current user may have only the DELETE privilege but not SELECT
+            currentSession.setBypassAuthorizerCheck(true);
+            List<StatementBase> parse = SqlParser.parse(fakeSql, currentSession.getSessionVariable());
             StatementBase selectStmt = parse.get(0);
             Analyzer.analyze(selectStmt, ConnectContext.get());
             ExecPlan plan = StatementPlanner.plan(selectStmt, ConnectContext.get());
@@ -318,6 +321,8 @@ private List<String> partitionPruneForDelete(DeleteStmt stmt, OlapTable table) {
         } catch (Exception e) {
             LOG.warn("failed to do partition pruning for delete {}", stmt.toString(), e);
             return Lists.newArrayList(table.getVisiblePartitionNames());
+        } finally {
+            currentSession.setBypassAuthorizerCheck(false);
         }
         List<Long> selectedPartitionId = physicalOlapScanOperator.getSelectedPartitionId();
         return ListUtils.emptyIfNull(selectedPartitionId)

fe/fe-core/src/main/java/com/starrocks/qe/ConnectContext.java

@@ -200,6 +200,9 @@ public class ConnectContext {
     protected boolean isStatisticsContext = false;
     protected boolean needQueued = true;
 
+    // Bypass the authorizer check for certain cases
+    protected boolean bypassAuthorizerCheck = false;
+
     protected DumpInfo dumpInfo;
 
     // The related db ids for current sql
@@ -341,17 +344,10 @@ public void setThreadLocalInfo() {
         threadLocalInfo.set(this);
     }
 
-    /**
-     * Set this connect to thread-local if not exists
-     *
-     * @return set or not
-     */
-    public boolean setThreadLocalInfoIfNotExists() {
-        if (threadLocalInfo.get() == null) {
-            threadLocalInfo.set(this);
-            return true;
-        }
-        return false;
+    public static ConnectContext exchangeThreadLocalInfo(ConnectContext ctx) {
+        ConnectContext prev = threadLocalInfo.get();
+        threadLocalInfo.set(ctx);
+        return prev;
     }
 
     public void setGlobalStateMgr(GlobalStateMgr globalStateMgr) {
@@ -759,6 +755,14 @@ public void setNeedQueued(boolean needQueued) {
         this.needQueued = needQueued;
     }
 
+    public boolean isBypassAuthorizerCheck() {
+        return bypassAuthorizerCheck;
+    }
+
+    public void setBypassAuthorizerCheck(boolean value) {
+        this.bypassAuthorizerCheck = value;
+    }
+
     public ConnectContext getParent() {
         return parent;
     }
@@ -934,8 +938,15 @@ public StmtExecutor executeSql(String sql) throws Exception {
         return executor;
     }
 
+    /**
+     * Bind the context to current scope, exchange the context if it's already existed
+     * Sample usage:
+     * try (var guard = context.bindScope()) {
+     * ......
+     * }
+     */
     public ScopeGuard bindScope() {
-        return ScopeGuard.setIfNotExists(this);
+        return ScopeGuard.bind(this);
     }
 
     /**
@@ -944,21 +955,30 @@ public ScopeGuard bindScope() {
     public static class ScopeGuard implements AutoCloseable {
 
         private boolean set = false;
+        private ConnectContext prev;
 
         private ScopeGuard() {
         }
 
-        public static ScopeGuard setIfNotExists(ConnectContext session) {
+        private static ScopeGuard bind(ConnectContext session) {
             ScopeGuard res = new ScopeGuard();
-            res.set = session.setThreadLocalInfoIfNotExists();
+            res.prev = exchangeThreadLocalInfo(session);
+            res.set = true;
             return res;
         }
 
+        public ConnectContext prev() {
+            return prev;
+        }
+
         @Override
         public void close() {
             if (set) {
                 ConnectContext.remove();
             }
+            if (prev != null) {
+                prev.setThreadLocalInfo();
+            }
         }
     }
 

fe/fe-core/src/main/java/com/starrocks/qe/StmtExecutor.java

@@ -1287,11 +1287,9 @@ private void executeAnalyze(AnalyzeStmt analyzeStmt, AnalyzeStatus analyzeStatus
         // from current session, may execute analyze stmt
         statsConnectCtx.getSessionVariable().setStatisticCollectParallelism(
                 context.getSessionVariable().getStatisticCollectParallelism());
-        statsConnectCtx.setThreadLocalInfo();
-        try {
+        statsConnectCtx.setStatisticsConnection(true);
+        try (ConnectContext.ScopeGuard guard = statsConnectCtx.bindScope()) {
             executeAnalyze(statsConnectCtx, analyzeStmt, analyzeStatus, db, table);
-        } finally {
-            ConnectContext.remove();
         }
 
     }

fe/fe-core/src/main/java/com/starrocks/sql/StatementPlanner.java

@@ -115,7 +115,9 @@ public static ExecPlan plan(StatementBase stmt, ConnectContext session,
             analyzeStatement(stmt, session, dbs);
 
             // Authorization check
-            Authorizer.check(stmt, session);
+            if (!session.isBypassAuthorizerCheck()) {
+                Authorizer.check(stmt, session);
+            }
             if (stmt instanceof QueryStatement) {
                 OptimizerTraceUtil.logQueryStatement("after analyze:\n%s", (QueryStatement) stmt);
             }

fe/fe-core/src/main/java/com/starrocks/statistic/AnalyzeMgr.java

@@ -422,11 +422,12 @@ public void clearStatisticFromDroppedTable() {
         tableIdHasDeleted.removeAll(tables);
 
         ConnectContext statsConnectCtx = StatisticUtils.buildConnectContext();
-        statsConnectCtx.setThreadLocalInfo();
-        statsConnectCtx.setStatisticsConnection(true);
+        try (ConnectContext.ScopeGuard guard = statsConnectCtx.bindScope()) {
+            statsConnectCtx.setStatisticsConnection(true);
 
-        dropBasicStatsMetaAndData(statsConnectCtx, tableIdHasDeleted);
-        dropHistogramStatsMetaAndData(statsConnectCtx, tableIdHasDeleted);
+            dropBasicStatsMetaAndData(statsConnectCtx, tableIdHasDeleted);
+            dropHistogramStatsMetaAndData(statsConnectCtx, tableIdHasDeleted);
+        }
     }
     public void recordDropPartition(long partitionId) {
         dropPartitionIds.add(partitionId);
@@ -596,17 +597,19 @@ private void clearStaleStatsWhenStarted() {
 
     public void dropBasicStatsMetaAndData(ConnectContext statsConnectCtx, Set<Long> tableIdHasDeleted) {
         StatisticExecutor statisticExecutor = new StatisticExecutor();
-        for (Long tableId : tableIdHasDeleted) {
-            BasicStatsMeta basicStatsMeta = basicStatsMetaMap.get(tableId);
-            if (basicStatsMeta == null) {
-                continue;
+        try (ConnectContext.ScopeGuard guard = statsConnectCtx.bindScope()) {
+            for (Long tableId : tableIdHasDeleted) {
+                BasicStatsMeta basicStatsMeta = basicStatsMetaMap.get(tableId);
+                if (basicStatsMeta == null) {
+                    continue;
+                }
+                // Both types of tables need to be deleted, because there may have been a switch of
+                // collecting statistics types, leaving some discarded statistics data.
+                statisticExecutor.dropTableStatistics(statsConnectCtx, tableId, StatsConstants.AnalyzeType.SAMPLE);
+                statisticExecutor.dropTableStatistics(statsConnectCtx, tableId, StatsConstants.AnalyzeType.FULL);
+                GlobalStateMgr.getCurrentState().getEditLog().logRemoveBasicStatsMeta(basicStatsMetaMap.get(tableId));
+                basicStatsMetaMap.remove(tableId);
             }
-            // Both types of tables need to be deleted, because there may have been a switch of
-            // collecting statistics types, leaving some discarded statistics data.
-            statisticExecutor.dropTableStatistics(statsConnectCtx, tableId, StatsConstants.AnalyzeType.SAMPLE);
-            statisticExecutor.dropTableStatistics(statsConnectCtx, tableId, StatsConstants.AnalyzeType.FULL);
-            GlobalStateMgr.getCurrentState().getEditLog().logRemoveBasicStatsMeta(basicStatsMetaMap.get(tableId));
-            basicStatsMetaMap.remove(tableId);
         }
     }