Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make favicon configurable #150

Open
StefMa opened this issue Jan 20, 2023 · 2 comments
Open

Make favicon configurable #150

StefMa opened this issue Jan 20, 2023 · 2 comments

Comments

@StefMa
Copy link
Owner

StefMa commented Jan 20, 2023

I had to dig into the code to find out that the favicon can be replaced by adding a favicon into static/images.
We should either document this, or maybe better, add to the config.yml instead... 🤔
@StefMa StefMa mentioned this issue Feb 23, 2023
Merged
@StefMa
Copy link
Owner Author

StefMa commented Feb 23, 2023

We documented the favicon in #154
Now we should make it more dynamic by make it possible to configure it via the config.yml file...

@StefMa StefMa changed the title [Dcoumentation] favicon Make favicon configurable Feb 23, 2023
@lextm
Copy link
Contributor

lextm commented Apr 14, 2024

There doesn't seem to be a need to go through config.yml, as theme users can simply dump the files in a folder like static/favicon.

We found it is more reasonable to revise css.html to support more favicon options, so we did our own commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lextm @StefMa