Skip to content
This repository was archived by the owner on Jun 29, 2022. It is now read-only.

Commit bcfda10

Browse files
authored
Merge pull request #11 from Stewart86/cleanup
closing #8 Cleanup
2 parents 1fe760e + 6ddd5b4 commit bcfda10

File tree

4 files changed

+10
-35
lines changed

4 files changed

+10
-35
lines changed

aiocloudflare/cloudflare.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,9 @@ def __init__(
3939
email: Optional[str] = None,
4040
token: Optional[str] = None,
4141
certtoken: Optional[str] = None,
42-
raw: Optional[str] = None, # TODO
43-
profile: Optional[str] = None, # TODO
4442
user_agent: Optional[dict[str, str]] = None,
4543
base_url: Optional[str] = None,
4644
debug: Optional[bool] = False,
47-
test: Optional[bool] = None, # TODO
4845
logger: Optional[Logger] = None,
4946
config: Optional[Config] = None,
5047
) -> None:
@@ -73,14 +70,13 @@ def __init__(
7370
API token from Cloudflare. Defaults to None.
7471
certtoken (Optional[str], optional):
7572
To use Cert Token **current not implemented**. Defaults to None.
76-
raw (Optional[str], optional): Not Implemented. Defaults to None.
73+
user_agent (Optional[dict[str,str]], optional):
74+
To modify the user agent header send to Cloudflare API. Most
75+
for Cloudflare support when erro occurs.
7776
base_url (Optional[str], optional): If not provided, it will
7877
defaults to cloudflare's v4 API. Defaults to None.
7978
debug (Optional[bool], optional): To set debug as true, logs will
8079
be more verbose. Defaults to False.
81-
test (Optional[bool], optional): If True, config will ignore all
82-
args in the init method and use a seperate config must be
83-
provided. Defaults to None.
8480
config (Optional[Config], optional): An optional config class
8581
include all settings. Defaults to None.
8682
"""
@@ -91,12 +87,9 @@ def __init__(
9187
email,
9288
token,
9389
certtoken,
94-
raw,
95-
profile,
9690
user_agent,
9791
base_url,
9892
debug,
99-
test,
10093
)
10194

10295
if logger:

aiocloudflare/commons/config.py

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -32,39 +32,21 @@ def __init__(
3232
email: Optional[str] = None,
3333
token: Optional[str] = None,
3434
certtoken: Optional[str] = None,
35-
raw: Optional[str] = None, # TODO
36-
profile: Optional[str] = None, # TODO
3735
user_agent: Optional[dict[str, str]] = None,
3836
base_url: Optional[str] = None,
3937
debug: Optional[bool] = False,
40-
test: Optional[bool] = None, # TODO
4138
) -> None:
42-
self.TEST: bool = self.__env_or_init(test, "TEST", False)
43-
self.USER_AGENT: str = self.__env_or_init(
44-
user_agent, "USER_AGENT", "aiocloudflare"
45-
)
46-
# skip initialising for tests
47-
# hacky implementation, should use .env or .testenv for it
48-
# TODO
49-
if test:
50-
self.EMAIL = None
51-
self.TOKEN = None
52-
self.CERTTOKEN = None
53-
self.BASE_URL = None
54-
self.DEBUG = False
55-
return
56-
5739
self.EMAIL = self.__env_or_init(email, "CF_API_EMAIL")
5840
self.TOKEN = self.__env_or_init(token, "CF_API_KEY")
5941
self.CERTTOKEN = self.__env_or_init(certtoken, "CF_API_CERTKEY")
42+
self.USER_AGENT: str = self.__env_or_init(
43+
user_agent, "USER_AGENT", "aiocloudflare"
44+
)
6045
self.BASE_URL = self.__env_or_init(
6146
base_url, "CF_API_URL", "https://api.cloudflare.com/client/v4"
6247
)
6348
self.DEBUG = self.__env_or_init(debug, "DEBUG", False)
6449

65-
self.RAW = None
66-
self.PROFILE = self.__env_or_init(profile, "CF_PROFILE")
67-
6850
def __env_or_init(
6951
self, var: Any, env_key: str, default_value: Optional[Any] = None
7052
) -> Any:

noxfile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717

1818
package = "aiocloudflare"
19-
python_versions = ["3.9", "3.8", "3.7"]
19+
python_versions = ["3.9"]
2020
nox.needs_version = ">= 2021.6.6"
2121
nox.options.sessions = ("pre-commit", "safety", "mypy", "tests")
2222

@@ -113,7 +113,7 @@ def mypy(session: Session) -> None:
113113
def tests(session: Session) -> None:
114114
"""Run the test suite."""
115115
session.install(".")
116-
session.install("coverage[toml]", "pytest", "pygments", "respx")
116+
session.install("coverage[toml]", "pytest", "pygments", "respx", "pytest-asyncio")
117117
try:
118118
session.run("coverage", "run", "--parallel", "-m", "pytest", *session.posargs)
119119
finally:

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
[tool.poetry]
22
name = "aiocloudflare"
3-
version = "0.1.3-alpha"
3+
version = "0.2.0-beta"
44
description = "A Cloudflare API wrapper for Python with asyncio support"
55
authors = ["Stewart Wong <[email protected]>"]
66
license = "MIT"
77
readme = "README.rst"
88
homepage = "https://github.com/stewart86/aiocloudflare"
99
repository = "https://github.com/stewart86/aiocloudflare"
1010
classifiers = [
11-
"Development Status :: 2 - Pre-Alpha",
11+
"Development Status :: 4 - Beta",
1212
"Intended Audience :: Developers",
1313
"Programming Language :: Python :: 3.9",
1414
"Topic :: Software Development :: Libraries :: Python Modules",

0 commit comments

Comments
 (0)