Questions about windForce generation

[weywocketer]

Hello,
I've got some questions regarding how the windForce generation in the WaterInteraction.cs script works.

The calculation of the windForce is actually happening inside the if block from line 542:

// force and particles can happens a bit outside water
if (depth > -0.5f*triangleSize[t])

It seems as this 'if' was intended for the buoyancy forces, so I'm wondering why the windForce generation is in there as well. It causes the windForce to be applied only to triangles which are close enough to the waterline to fulfil the condition. I was rather expecting that it should be applied to all triangles which are above the water.

I've also noticed that the windForce calculation (line 640) does not take the triangleArea into account.

It seems that these two issues make the windForce generated on the hull unexpectedly small, so I'd like to ask if it is the intended behaviour? Or perhaps I've missed some important aspect here?

PS, I greatly appreciate your package and all the work that you've put into it. It's a really amazing product. Thank you for sharing it with the world!

[Stormrider31]

Hi Weywocketer,

This is indeed a mistake that comes from when I added this first IF block to optimize the simulation, I forgot its impact on the wind force feature that I rarely used myself.

To correct this you can cut the lines [633;644] and paste them at current line 693 just like you would expect it to work. I'll commit this fix.

EDIT : wait this is not as easy, some variable got out of the scope. I'll have to see this more thoroughly

[weywocketer]

Thanks for the reply! Yeah, moving the section [633;644] outside of the IF, alongside with three variables that would otherwise get out of scope seems to work just fine for me. I've also modified the line where windForce is calculated, so it actually includes the triangleArea:

Vector3 windForce = triangleArea[t] * 0.5f * Mathf.Sign(normalWindVelocity) * normalWindVelocity * normalWindVelocity * draggedWorldNormal;