Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/windows build run issues #68

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/windows build run issues #68

wants to merge 2 commits into from
+16 −4

Conversation

TaejusYee2001
Copy link

@TaejusYee2001 TaejusYee2001 commented Feb 3, 2025 •
edited
Loading

fix: issues occurring when building and running Preswald on Windows

This PR ensures:

  • README.md and example scripts (hello.py) are opened using utf-8.
  • The npm path is obtained using shutil.which() to avoid lack of path availability when running a subprocess command.
  • The current working directory is set to the script location using os.chdir() before running the example script.

Fixes #65
Fixes #59

shivam-singhal
shivam-singhal requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@shivam-singhal shivam-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Had some changes in the recent refactor, can you rebase and make sure this works?

@TaejusYee2001 TaejusYee2001 force-pushed the fix/windows-build-run-issues branch from 6ac216c to 6f4fd73 Compare February 4, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivam-singhal shivam-singhal shivam-singhal requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@TaejusYee2001 @shivam-singhal @Taejusyee