Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabsize width is reduced #847

Open
Zarthus opened this issue Feb 8, 2019 · 7 comments
Open

Tabsize width is reduced #847

Zarthus opened this issue Feb 8, 2019 · 7 comments
Labels
bug 🐛 Something isn't working chrome 🙊

Comments

@Zarthus
Copy link

Zarthus commented Feb 8, 2019

The tabsize/width of \t is decreased to a single space. This makes it very hard to identify indentation properly.

  • Browser: Chrome
  • Operating System: Win 10 (latest)
  • Screenshot:
    Dark:
    img
    None:
    img

GIF:
gif

  • HTML of the section where the issue occurs:
<td class="code-review blob-code blob-code-addition">
        <button class="btn-link add-line-comment js-add-line-comment js-add-split-line-comment" data-type="addition" data-path="src/plugins/inputs/ctcp.js" data-anchor="diff-14eb41fc8833d241324d7684de7b7e8e" data-position="11" data-original-line="+		chan.pushMessage(this, new Msg({" data-line="9" data-side="right" type="button" aria-label="Add line comment">
           <svg class="octicon octicon-plus" viewBox="0 0 12 16" version="1.1" width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M12 9H7v5H5V9H0V7h5V2h2v5h5v2z"></path></svg>
         </button>

      <span class="blob-code-inner blob-code-marker" data-code-marker="+">		<span class="pl-smi">chan</span>.<span class="pl-en">pushMessage</span>(<span class="pl-c1">this</span>, <span class="pl-k">new</span> <span class="pl-en">Msg</span>({</span>

    </td>
@silverwind
Copy link
Member

silverwind commented Feb 8, 2019

If you're using Stylus, you can go into the style optiond to set a preferred tab size. Default for the style is 2, default on GitHub is 8.

Your rendering for the first indented line does seem to have a bit small tab width thought, maybe that is a separate issue.

@Zarthus
Copy link
Author

Zarthus commented Feb 8, 2019

This works, thanks!

Is there a reason the default is 2 spaces?

@silverwind
Copy link
Member

It's mostly a personal preference of the authors :)

@silverwind
Copy link
Member

We do have a separate tab-size addon (https://github.com/StylishThemes/GitHub-tab-size), so I think it's time we drop tab modification out of the style.

@Zarthus
Copy link
Author

Zarthus commented Feb 8, 2019

Should we close this task? It's resolved to my desires, but you may still be interested in investigating the

Your rendering for the first indented line does seem to have a bit small tab width thought, maybe that is a separate issue.

bit (or discuss the latter point you raised in the above comment)

@silverwind
Copy link
Member

Let's leave it open as a reminder to do something about tab sizes.

@the-j0k3r the-j0k3r added chrome 🙊 bug 🐛 Something isn't working labels Feb 9, 2019
@the-j0k3r
Copy link
Member

Also tabsize related #543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working chrome 🙊
Projects
None yet
Development

No branches or pull requests

3 participants