Skip to content

New theme elements #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FichteFoll opened this issue Jan 19, 2019 · 3 comments
Closed

New theme elements #219

FichteFoll opened this issue Jan 19, 2019 · 3 comments
Milestone

Comments

@FichteFoll
Copy link
Member

FichteFoll commented Jan 19, 2019

I added the new attributes in #210 because they are needed for proper highlighting, but I haven't added the new elements because I'm waiting on an update of the official docs for those.

https://www.sublimetext.com/docs/3/dev/themes.html

I might also need to tweak the CSS color function since ST added a few custom modifier functions that the CSS4 draft does not have. Most likely need to implement my own version of that instead of relying on the shipped CSS.sublime-syntax. Update: fixed by #229

@FichteFoll
Copy link
Member Author

@deathaxe considering that you added many new theme properties, attributes, etc recently, do you happen to know where we stand with out coverage currently?

@deathaxe
Copy link
Member

deathaxe commented Mar 1, 2019

Not for sure. Just added features/fixed stuff I realized in the Default.sublime-them while working on DA UI successor. Did not walk through the latest docs in detail.

@FichteFoll
Copy link
Member Author

Went through the changelog on the docs and added all things still missing in 8411ab6 and 351a4c9.

@FichteFoll FichteFoll added this to the 3.2.8 milestone Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants