Skip to content

CI: Add syntax tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

CI: Add syntax tests #8

merged 2 commits into from
Nov 19, 2024

Conversation

deathaxe
Copy link
Member

This PR adds automated syntax tests for all covered ST4 releases.

@FichteFoll FichteFoll force-pushed the pr/ci-syntax-tests branch 3 times, most recently from 6e7c0d0 to 80eaf91 Compare November 18, 2024 22:30
@FichteFoll
Copy link
Member

FichteFoll commented Nov 18, 2024

PTAL since I revised it a bit.

Unfortunately, the configuration causes it to run each job twice now when a PR is created from a branch of the same repo, but I gave up trying to circumvent that after a short while.

@deathaxe
Copy link
Member Author

Well, we probably need only one of push or pull_request. I can remember having struggled with it for Package Control as its tests are quite expensive. As a result it uses only push.

@deathaxe deathaxe merged commit 5e17853 into main Nov 19, 2024
21 checks passed
@deathaxe deathaxe deleted the pr/ci-syntax-tests branch November 19, 2024 10:02
@FichteFoll
Copy link
Member

Since I don't think we're going to use a large list of branches, I suppose we can simply use push for the main branch and pull_request for everything else. It's not like we need CI to test local developments because we can quickly run tests in ST anyway.

@FichteFoll FichteFoll added this to the 5.0.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants