You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Discovered by observing the github actions hosted darwin amd64 tests. Though this is most apparent in test environments, it could happen in a live deployment just the same, so we will need a way to resolve this.
The https://github.com/Showmax/go-fqdn library does not have an interface that allows us to pass a context in order to effectively resolve with timeout. We should probably set a timeout for this action, and maybe have some way to limit depth of whatever lookup it may be doing.
The text was updated successfully, but these errors were encountered:
c-kruse
changed the title
[sumologicextension] FQDN hostname resolution hangs in github actions hosts
[sumologicextension] FQDN hostname resolution can sometimes hang
Oct 23, 2023
As noted by @rnishtala-sumo, the collector already has a facility for getting the collector's hostname, the resource detection processor.
I think there is value in finding a way to allow for some consistency between this extension and what is configured in resourcedetection. As I understand, when installed and configured by sumo it should be consistent https://github.com/SumoLogic/sumologic-otel-collector/blob/v0.88.0-sumo-0/examples/sumologic.yaml#L81 (try to resolve fqdn then us os.hostname), but the resourcedetection processor is configurable in ways this extension is not.
Discovered by observing the github actions hosted darwin amd64 tests. Though this is most apparent in test environments, it could happen in a live deployment just the same, so we will need a way to resolve this.
The https://github.com/Showmax/go-fqdn library does not have an interface that allows us to pass a context in order to effectively resolve with timeout. We should probably set a timeout for this action, and maybe have some way to limit depth of whatever lookup it may be doing.
The text was updated successfully, but these errors were encountered: