Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sumologicextension] FQDN hostname resolution can sometimes hang #1295

Open
c-kruse opened this issue Oct 23, 2023 · 1 comment
Open

[sumologicextension] FQDN hostname resolution can sometimes hang #1295

c-kruse opened this issue Oct 23, 2023 · 1 comment

Comments

@c-kruse
Copy link
Contributor

c-kruse commented Oct 23, 2023

Discovered by observing the github actions hosted darwin amd64 tests. Though this is most apparent in test environments, it could happen in a live deployment just the same, so we will need a way to resolve this.

The https://github.com/Showmax/go-fqdn library does not have an interface that allows us to pass a context in order to effectively resolve with timeout. We should probably set a timeout for this action, and maybe have some way to limit depth of whatever lookup it may be doing.

@c-kruse c-kruse changed the title [sumologicextension] FQDN hostname resolution hangs in github actions hosts [sumologicextension] FQDN hostname resolution can sometimes hang Oct 23, 2023
@c-kruse
Copy link
Contributor Author

c-kruse commented Oct 24, 2023

As noted by @rnishtala-sumo, the collector already has a facility for getting the collector's hostname, the resource detection processor.

I think there is value in finding a way to allow for some consistency between this extension and what is configured in resourcedetection. As I understand, when installed and configured by sumo it should be consistent https://github.com/SumoLogic/sumologic-otel-collector/blob/v0.88.0-sumo-0/examples/sumologic.yaml#L81 (try to resolve fqdn then us os.hostname), but the resourcedetection processor is configurable in ways this extension is not.

https://github.com/SumoLogic/sumologic-otel-collector/pull/1296/files#r1369182047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant