Skip to content

Commit 0f48456

Browse files
authored
Merge pull request #323 from Sreejit-K/osCreatedAt_format_changes
Fixed the timeStamp format for Attestation update work flow
2 parents 1ecda5b + e3676f6 commit 0f48456

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

java/middleware-commons/src/main/java/dev/sunbirdrc/registry/middleware/util/JSONUtil.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import java.io.IOException;
2121
import java.lang.reflect.Type;
2222
import java.nio.charset.StandardCharsets;
23+
import java.time.LocalDateTime;
24+
import java.time.format.DateTimeFormatter;
2325
import java.util.*;
2426
import java.util.regex.Matcher;
2527
import java.util.regex.Pattern;
@@ -505,7 +507,12 @@ private static JsonNode searchClaimOsIdFromRequestProperties(ArrayNode arrayNode
505507
}
506508
List<JsonNode> nodeList = new ArrayList<>();
507509
arrayNode.elements().forEachRemaining(nodeList::add);
508-
nodeList.sort(Comparator.comparingLong(node -> node.get("osCreatedAt").asLong()));
510+
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss");
511+
nodeList.sort(Comparator.comparing(node -> {
512+
String dateString = node.get("osCreatedAt").asText();
513+
LocalDateTime dateTime = LocalDateTime.parse(dateString, formatter);
514+
return dateTime;
515+
}));
509516
return nodeList.get(nodeList.size() -1 );
510517
}
511518

java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryClaimsController.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
import org.springframework.web.client.HttpServerErrorException;
2727

2828
import javax.servlet.http.HttpServletRequest;
29+
import java.time.LocalDateTime;
30+
import java.time.ZoneOffset;
31+
import java.time.format.DateTimeFormatter;
2932
import java.util.Collections;
3033
import java.util.Date;
3134

@@ -143,7 +146,7 @@ public ResponseEntity<Object> riseAttestation(HttpServletRequest request, @Reque
143146
if(!propertyData.isNull()) {
144147
attestationRequest.setPropertyData(propertyData);
145148
}
146-
attestationRequest.setOsCreatedAt(new Date());
149+
attestationRequest.setOsCreatedAt(LocalDateTime.ofInstant(new Date().toInstant(), ZoneOffset.UTC).format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss")) );
147150
attestationRequest.setUserId(userId);
148151
attestationRequest.setEmailId(emailId);
149152
String attestationOSID = registryHelper.triggerAttestation(attestationRequest, attestationPolicy);

java/registry/src/main/java/dev/sunbirdrc/registry/model/dto/AttestationRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ public class AttestationRequest {
2323
private Map<String, List<String>> propertiesOSID;
2424
private JsonNode propertyData;
2525
private String emailId;
26-
private Date osCreatedAt;
26+
private String osCreatedAt;
2727
}

0 commit comments

Comments
 (0)